Mapstruct from string to nested object for multiple fields with the same type

Question

I have Entity class with fields:

Client sender;
Client recipient;

I have DTO class with fields:

long senderId;
long recipientId;

If I do like this:

@Mappings({ @Mapping(source = "senderId", target = "sender.id"), @Mapping(source = "recipientId", target = "recipient.id") })

Mapstruct will generate code like this:

public Entity toEntity(DTO) {
        //...
        entity.setSender( dtoToClient( dto ) );
        entity.setRecipient( dtoToClient( dto ) );
        //...

    protected Client dtoToClient(Dto dto) {
        Client client = new Client();
        client.setId( dto.getRecipientId() ); // mapstruct takes recipient id for sender and recipient
        return client;
    }
}

Mapstruct takes recipient id for sender and recipient instead of recipient id to create Client recipient and sender id to create Client sender.

So the better way I've found is using expression that is not so elegant as far as I can see:

@Mappings({
      @Mapping(target = "sender", expression = "java(createClientById(dto.getSenderId()))"),
      @Mapping(target = "recipient", expression = "java(createClientById(dto.getRecipientId()))")
})

Could you plz suggest me how to map them?

This is a bug. I have created #1148 for this

Filip
– Filip

2017-03-22 18:14:37 +00:00
Commented Mar 22, 2017 at 18:14 — Filip
– Filip, Commented Mar 22, 2017 at 18:14

Filip · Accepted Answer · 2017-03-23 21:18:40Z

6

Until the bug is resolved you will need to define the methods and use qualifedBy or qualifiedByName. More info about there here in the documentation.

Your mapper should look like:

@Mapper
public interface MyMapper {

    @Mappings({
        @Mapping(source = "dto", target = "sender", qualifiedByName = "sender"),
        @Mapping(source = "dto", target = "recipient", qualifiedByName = "recipient")
    })
    Entity toEntity(Dto dto);


    @Named("sender")
    @Mapping(source = "senderId", target = "id")
    Client toClient(Dto dto);

    @Named("recipient")
    @Mapping(source = "recipientId", target = "id")
    Client toClientRecipient(Dto dto);
}

answered Mar 23, 2017 at 21:18

Filip

21.9k7 gold badges61 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Mapstruct from string to nested object for multiple fields with the same type

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related