PHP (7.1) inheritance issue

Question

I have the following structure:

class AffiliateRepository extends GenericRepository implements IAffiliateRepository {

}


abstract class GenericRepository  {
    public function save(BaseModel $model) : int{
        $model->save();
        return $model->getId();
    }

}

interface IAffiliateRepository  {

    public function save(Affiliate $affiliate) : int;
}

public class Affiliate extends BaseModel{}


$affiliateRepository  = new AffiliateRepository();
$affiliateRepository->save(new Affiliate());

I am expecting GenericRepository to take care on the save action.

but I'm getting the following error:

Declaration of App\Services\AffiliateRepository::save(App\Models\Affiliate $affiliate): int should be compatible with App\Services\GenericRepository::save(App\Models\BaseModel $model): int

Why is that? Affiliate inherits from BaseModel.
Whats the best way to overcome that and let GenericRepository handle the save function call.

thanks

Because the method signature of GenericRepository::save is not met. That method says that it can accept any BaseModel, whereas IAffiliateRepository::save only accepts Affiliate instances. So it clearly breaks the contract. — enricog
– enricog, Commented Apr 3, 2017 at 6:43
Is \App\Models\Affiliate a descendant of \App\Models\BaseModel? — AwesomeGuy
– AwesomeGuy, Commented Apr 3, 2017 at 6:58
"Why is that? Affiliate inherits from BaseModel." -- because PHP is not C++ :-( — axiac
– axiac, Commented Apr 3, 2017 at 7:30

michail_w · Accepted Answer · 2017-04-03 06:41:20Z

1

Look at methods:

// GenericRepository
public function save(BaseModel $model)

// IAffiliateRepository
public function save(Affiliate $affiliate) : int;

Both classes have to expect the same type. If you implement IAffiliateRepository into GenericRepository class, it will be correct. You may also need to change variable names to be the same.

answered Apr 3, 2017 at 6:41

michail_w

4,4814 gold badges30 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Phil · Accepted Answer · 2017-04-03 06:45:00Z

0

Seems a bit messy but the problem is, in order for AffiliateRepository to implement the IAffiliateRepository, the signature of save must be

save(Affiliate $affiliate) : int

The implementation in GenericRepository does not satisfy this.

You could try this in AffiliateRepository...

public function save(Affiliate $affiliate) : int {
    return parent::save($affiliate);
}

answered Apr 3, 2017 at 6:45

Phil

166k25 gold badges265 silver badges269 bronze badges

Comments

Rad80 · Accepted Answer · 2017-04-03 06:48:47Z

0

@enricog gave the correct answer in a comment: to satisfy the interface the save method must accept any object that is a BaseModel. The method provided by IAffiliateRepository does not do that.

answered Apr 3, 2017 at 6:48

Rad80

8537 silver badges18 bronze badges

Collectives™ on Stack Overflow

PHP (7.1) inheritance issue

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related