how to replace same words in javascript multiple times?

Question

Our developer used this phone number 1-866-579-469 all over the website but the correct phone number is 1-866-579-4269. I have written a javascript function to replace all occurrences:

var nodes,currentElement,oldtext,newtext,replaced,count;
function replaceAll(nodes,oldtext,newtext,replaced) { 
    count = 0
  for (var i = 0; i < nodes.length; i++) {
    currentElement  = nodes[i].innerHTML;  
    replaced = currentElement.replace(oldtext,newtext);
    count++;
  }
  console.log("Edited: "+ count + " items");
}

oldtext = "1-866-579-469";
newtext = "1-866-579-4269";
nodes = document.getElementsByTagName('*');

replaceAll(nodes,oldtext,newtext,replaced);

if counting items is not critical, the replacement can be done in a much shorter way — RomanPerekhrest
– RomanPerekhrest, Commented Apr 5, 2017 at 19:53

Ilyas karim · Accepted Answer · 2017-04-05 20:17:57Z

1

Your code works but you missed to update the replaced string. This should work:

var nodes,currentElement,oldtext,newtext,replaced,count;
function replaceAll(nodes,oldtext,newtext,replaced) { 
    count = 0
  for (var i = 0; i < nodes.length; i++) {
    currentElement  = nodes[i].innerHTML;  
    replaced = currentElement.replace(oldtext,newtext);
    nodes[i].innerHTML = replaced;
    count++;
  }
  console.log("Edited: "+ count + " items");
}

oldtext = "1-866-579-469";
newtext = "1-866-579-4269";
nodes = document.getElementsByTagName('*');

replaceAll(nodes,oldtext,newtext,replaced);

Codepen Here

edited Apr 5, 2017 at 20:17

answered Apr 5, 2017 at 19:50

Ilyas karim

4,8124 gold badges35 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

how to replace same words in javascript multiple times?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related