Batch file - IF Error

Question

I need help with my if command in my file converter. I keep changing the command a bit, but it just returns with

(exit) was unexpected at this time.

And then it closes command prompt. The if command is:

if %success% == 0 (exit) else (goto converter)

Please help.

In cases like this, be sure to remove or comment out ECHO OFF statements so that the processing will be shown. At the end of a .bat script, you probably want EXIT /B. See EXIT /?. — lit
– lit, Commented Apr 16, 2017 at 12:43
If you just want to terminate the batch script and not close the command window then use GOTO :EOF instead of exit. EOF is an implicit label at the very end of any batch file. — user1016274
– user1016274, Commented Apr 17, 2017 at 13:10

Magoo · Accepted Answer · 2017-04-16 04:03:49Z

2

In all probability, success is not assigned, ie. set to nothing

if "%success%"=="0" (exit) else (goto converter)

should succeed - but remember exit will terminate the cmd session...

answered Apr 16, 2017 at 4:03

Magoo

80.8k8 gold badges68 silver badges92 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Puppy288 Over a year ago

Okay, that didn't work but i fixed it. I needed to type "if "%success%" == "0" (exit)"

Magoo Over a year ago

I can't see a difference. Surrounding a string in backticks will shade the background, single-* will italicise and double-* make bold. May help with the quote-count.

Puppy288 Over a year ago

I added spaces.

Magoo Over a year ago

Hmm - it might be that if you are using a word-processor like utility to edit your code the quotes may be being converted to "smart quotes". This will work after a fashion because it makes the first string non-empty, but if the contents of that string include a space (as may be set by a set /p command) it would fail. The quotes need to be strictly " as used by editors like notepad++ or editplus (amonst others). Afraid a venerable old program just doesn't quite get these new-fangled ideas. If this is the case as I suspect, the spaces are optional.

Puppy288 Over a year ago

It was Notepad++ set to Batch.

MOBASHIR IMAM · Accepted Answer · 2017-04-17 12:03:35Z

0

Instead of using goto use call and write exit after the if - else condition

set /A success=1
if %success%==0 ( exit ) else ( call :converter )
exit
:converter
echo In Conveter Function
pause

At the end of If-Else you must write exit otherwise converter function will be called twice

answered Apr 17, 2017 at 12:03

MOBASHIR IMAM

891 silver badge3 bronze badges

Collectives™ on Stack Overflow

Batch file - IF Error

2 Answers 2

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related