Spring MVC submit and bind object with a GET Request

Question

I like to show an object in its edit form which have been selected before from another page. The selection page transmits the id of the selected object via GET to my controller.

How can I enforce that the parameters get bind to a message object and this then automatically initialized by using my property editor?

At the moment I get always a new object with the id property set but not initialized through my property editor. What is missing in my GET request?

Example Selection JSP page, which will transmit the id via GET request to my controller:

<a href="message?id=${message.id}">${message.title}</a>

My Controller with PropertyEditor class and InitBind method

@Controller
public class MessageController {

  @Autowired
  private MessageRepository messageRepository;

  @RequestMapping(value="/message", method = RequestMethod.GET)
  public String handleMessage(Model model,@ModelAttribute("message") Message message) {

    // ISSUE Here the message object has only the "id" property set but get not initialized through the binder 
    System.out.println(message);

    return "message";
  }

  // inline property editor for message class 
  public class MessagePropertyEditor extends PropertyEditorSupport {
       @Override
       public String getAsText() {
          return String.valueOf(((Message) getValue()).getId());
       }

      @Override
      public void setAsText(String id) throws IllegalArgumentException {
          Message message = messageRepository.getMessageById(Integer.valueOf(id));
        setValue(message);
      }
    }

  @InitBinder
  public void initBinder(WebDataBinder binder) {
     binder.registerCustomEditor(Message.class, new MessagePropertyEditor());
  }
}

Example Message bean class

public class Message {
  private int id;

  private String title;

  private String text;

  // getter & setter methods
}

@ModelAttribute != @RequestParam.

M. Deinum
– M. Deinum

2017-04-30 16:48:56 +00:00
Commented Apr 30, 2017 at 16:48 — M. Deinum
– M. Deinum, Commented Apr 30, 2017 at 16:48

M. Deinum · Accepted Answer · 2017-04-30 16:58:05Z

1

Instead of using a PropertyEditor I suggest using a @ModelAttribute annotated method next to your @RequestMapping method.

@ModelAttribute
public Message modelAttribute(@RequestParam("id") int id) {
    return messageRepository.getMessageById(id);
}

Leave your @RequestMapping as is and you can remove your MessagePropertyEditor and @InitBinder annotated method. Which would result in something like this.

@Controller
@RequestMapping("/message")
public class MessageController {

  @Autowired
  private MessageRepository messageRepository;

  @ModelAttribute
  public Message modelAttribute(@RequestParam("id") int id) {
      return messageRepository.getMessageById(id);
  }

  @GetMapping
  public String handleMessage(Model model,@ModelAttribute("message") Message message) {
    System.out.println(message);

    return "message";
  }
}

answered Apr 30, 2017 at 16:58

M. Deinum

127k22 gold badges235 silver badges253 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

dabaicai · Accepted Answer · 2017-05-02 07:34:42Z

0

Add @RequestParam("id") to the paramter message like this:

public String handleMessage(Model model,@RequestParam("id") @ModelAttribute("message") Message message)

answered May 2, 2017 at 7:34

dabaicai

1,0098 silver badges9 bronze badges

Collectives™ on Stack Overflow

Spring MVC submit and bind object with a GET Request

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related