compare nested object values

Question

I have an object like so:

answers = {
   "q1" :  {
        "selected": "a",
        "correct": "b"
        },
   "q2": {
        "selected": "c",
        "correct": "d"
       },
    etc...
}

how do I compare selected and correct?

i'm trying

for (let key in answers) {
    if (key.selected === key.correct) {
        correct++;
    } else {
        incorrect++;
    }
}

but it doesn't work. I keep getting all questions marked correct. Pretty sure I need to do something else to go down a level in the object but not sure how to do it.

if I do answers[key].selected === answers[key].correct all come out as incorrect

Like answers[key].selected and answers[key].correct maybe? — Alon Eitan
– Alon Eitan, Commented May 15, 2017 at 20:38
key is a string of the current key. Please review how for-in works: developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/… — user1106925
– user1106925, Commented May 15, 2017 at 20:38

Joseph · Accepted Answer · 2017-05-15 20:39:36Z

1

Well... you're comparing the keys and not the values, where selected and correct will be undefined for both cases thus correct. You probably meant:

if (answers[key].selected === answers[key].correct) {

answered May 15, 2017 at 20:39

Joseph

120k31 gold badges186 silver badges238 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Alon Eitan Over a year ago

Should we answer this or close it as duplicate? There are probably at least 10 questions about for( key in object )

Vidro3 Over a year ago

this results in all my answers coming up as incorrect even though their values match in the answers object. any ideas if I have anything else wrong?

user1106925 Over a year ago

@Vidro3: WRT answers[key].selected === answers[key].correct Look at your data. In none of the objects is the .selected property the same as the .correct property. We don't know what you actually need because you haven't posted a complete yet minimal demo with a description of what the behavior should be beyond what you've shown.

Vidro3 Over a year ago

@squint ahh crud you are correct. some of my values are strings and others are int. Have to see how that happened. Thanks

Douglas Tyler Gordon · Accepted Answer · 2017-05-15 20:44:38Z

0

You want:

for (let key in answers) {
  if (answers[key]["selected"] === answers[key]["correct"]) {
    correct++; 
  } else {
    incorrect++; 
  }
}

edited May 15, 2017 at 20:44

answered May 15, 2017 at 20:39

Douglas Tyler Gordon

5543 silver badges10 bronze badges

1 Comment

user1106925 Over a year ago

answers.key.selected won't give the desired property, and you removed the variable let declaration for some reason.

JYoThI · Accepted Answer · 2017-05-15 20:49:31Z

0

you need to use it like this

answers = {
   "q1" :  {
        "selected": "a",
        "correct": "b"
        },
   "q2": {
        "selected": "c",
        "correct": "c"
       }

};
var correct=0;incorrect=0;
for (let key in answers) {
 
 if (answers[key].selected === answers[key].correct)
 {
   correct++;
 }
else
{
   incorrect++;
}
}
   console.log(correct);
   console.log(incorrect);

answered May 15, 2017 at 20:49

JYoThI

12.1k1 gold badge13 silver badges26 bronze badges

Collectives™ on Stack Overflow

compare nested object values

3 Answers 3

4 Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related