I want to pass variable in different function from same controller - Laravel

Question

public function chat($id,$team1,$team2){

    $relation=Crelation::where('match_id',$id)->where('first_team_id',$team1)->where('second_team_id',$team2)->first();

    if($relation == null){

        $data=[
            'match_id'=>$id,
            'first_team_id'=>$team1,
            'second_team_id'=>$team2
        ];

        $rel=  Crelation::create($data);
       $whatRelation=$rel->id;
        $this->sendMessage($whatRelation);

    }else{

    $whatRelation=$relation->id;
        $this->sendMessage($whatRelation);
    }

    return view('chat',compact('whatRelation'));
}


public function sendMessage(Request $request,$whatRelation)
{

    $id=(int)$whatRelation;

$user = Auth::user();

$message = $user->messages()->create([
    'message' => $request->input('message'),
    'crelation_id'=>$id


]);

broadcast(new MessageSent($user, $message))->toOthers();

return ['status' => 'Message Sent!'];
}

I get this error :

Argument 1 passed to App\Http\Controllers\ChatsController::sendMessage() must be an instance of Illuminate\Http\Request, integer given, called in C:\xampp\htdocs\ScrimWithMe\app\Http\Controllers\ChatsController.php on line 77 and defined

public function sendMessage(Request $request,$whatRelation) you are passing integer for first parameter it should be a request. — Anar Bayramov
– Anar Bayramov, Commented May 19, 2017 at 2:01
Hmm can you explain little more what i need to change i don't understand... — Dpower
– Dpower, Commented May 19, 2017 at 2:04
your passing single argument only $this->sendMessage($whatRelation); — JYoThI
– JYoThI, Commented May 19, 2017 at 2:05
pass like this $this->sendMessage(Request $request,$whatRelation); — JYoThI
– JYoThI, Commented May 19, 2017 at 2:09
pass like this $this->sendMessage(Request $request,$whatRelation); and access like this public function sendMessage($request,$whatRelation) — JYoThI
– JYoThI, Commented May 19, 2017 at 2:15

Demonyowh · Accepted Answer · 2017-05-19 03:32:07Z

3

you have two parameters needed for the sendMessage function .. but you're just passing one parameter ..

what you can do is add another parameter in your chat function chat like

public function chat(Request $request, $id,$team1,$team2){
    ....
    $this->sendMessage($request,$whatRelation);
}

then add a parameter in said function and that should do it ..

answered May 19, 2017 at 3:32

Demonyowh

1,6821 gold badge9 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Maninderpreet Singh · Accepted Answer · 2017-05-19 08:37:59Z

0

@Demonyowh explain all that why you get this error

I think it's factory design pattern there are two ways to solve your problem

If your method not used on any other place then remove first parameter and declare class on next line
```
METHOD(){
  $request = new Request();
  // your code;
}
```
Declare this class parameter in your __construct method

answered May 19, 2017 at 8:37

Maninderpreet Singh

2,5972 gold badges20 silver badges31 bronze badges

Collectives™ on Stack Overflow

I want to pass variable in different function from same controller - Laravel

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related