regexpr with preg_match(), pattern generate error

Question

In an old version of the docebo cms There is a check with preg_match(), which however generates error and returns false, Obviously there is something that does not go in the pattern But probably with an older PHP version it worked Does anyone know where the mistake is, And how would it be corrected?

$str="my_session";
clean_input_keys($str);

protected function clean_input_keys($str) {
    $pattern = '#^[&a-zA-Z0-9\.:_/-\s]+$#uD';
    $b_preg_match = preg_match($pattern, $str);
    var_dump($b_preg_match); //false //preg_match() returns FALSE if an error occurred. 
    if ( ! $b_preg_match) {
        exit('Disallowed key characters in global data.');
    }
    return $str;
}

Are you using Apple developer library? Did you read the error message? — Álvaro González
– Álvaro González, Commented Jun 15, 2017 at 14:13
The fragment /-\s doesn't seem to be valid. I would suggest /\s- instead. — Niet the Dark Absol
– Niet the Dark Absol, Commented Aug 2, 2017 at 17:22
Exactly, right now that tries to specify a character class "from / to whitespace" here, which of course makes no sense. (Btw., next time quote the error message please, instead of just telling us that you got one ...) — C3roe
– C3roe, Commented Aug 2, 2017 at 17:24
And I doubt this ever "worked" in older PHP versions ... much more likely that previously the error reporting was simply silenced, and this never did what it was supposed to in the first place ... — C3roe
– C3roe, Commented Aug 2, 2017 at 17:29

Wiktor Stribiżew · Accepted Answer · 2017-08-02 17:26:49Z

2

Note that preg_match returns false if there is an error in the pattern:

preg_match() returns 1 if the pattern matches given subject, 0 if it does not, or FALSE if an error occurred.

The error PHP throws is

PHP Warning: preg_match(): Compilation failed: invalid range in character class at offset 19 in /home/VaTQ68/prog.php on line 5

The unescaped hyphen inside a character class may form a range. A range between / and \s is not defined, hence the error.

You need to put the hyphen at the end or start of the character class, or escape it:

$pattern = '#^[&a-zA-Z0-9\.:_/\s-]+$#uD';
                                ^

See the PHP demo

answered Aug 2, 2017 at 17:26

Wiktor Stribiżew

631k41 gold badges502 silver badges632 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

regexpr with preg_match(), pattern generate error

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related