javascript: loop through elements and change their values [duplicate]

Question

My code doesn't change element values I'm working in Visual Studio 2017 with cordova inAppBrowser and I'm not sure why it doesn't work? My code:

var elements = document.getElementsByTagName('div');

for (var i = 0; i < elements.length; i++) { 
  elements[i].innerHTMl = "sometext";
}

I want my code to change each element. I appreciate your help

It works fine now with divs, but I used the same thing but with forms and elements[i].onSubmit = 'function(){ alert(string) }'; and it doesn't work on submiting a form, I also checked code with alert and it stays unchanged the whole time. If you have any idea why it doesn't work I would be soo thankful to you — Djordje Vujicic
– Djordje Vujicic, Commented Jul 10, 2017 at 17:48
I've found out the soulution for my problem. onsubmit didn't work for me so I used elements[i].action = 'javascript:myFunction();'; to do javascript action instead of redirecting page. Thanks everyone! — Djordje Vujicic
– Djordje Vujicic, Commented Jul 10, 2017 at 18:52

Nicolas · Accepted Answer · 2017-07-10 17:52:14Z

1

You have a typo in your code, it's innerHTML not innerHTMl here is a working fiddle https://jsfiddle.net/j8nbdm6b/2/

edited Jul 10, 2017 at 17:52

answered Jul 10, 2017 at 17:30

Nicolas

8,7364 gold badges25 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

16 Comments

Djordje Vujicic Over a year ago

Why you put consol.log? Is it necessary?

Nicolas Over a year ago

it is not, you can remove it.

Djordje Vujicic Over a year ago

Ok thanks, I'll check if it works in my full code and probably mark your answer as the best one

Djordje Vujicic Over a year ago

I found out that it changes action on elements[i].action = function() {myFunction()}; but it is no good because it sees it as a page URL, but onsubmit stays the same on elements[i].onsubmit = function() {myFunction()}; Anyways I'll try to figure out how to use action for this, probably I'll need javascript: before my code

Djordje Vujicic Over a year ago

I found out the solution elements[i].action = 'javascript:myFunction();'; should I put solution somewhere in this question? Because I'm new member on stack

|

grateful · Accepted Answer · 2017-07-10 17:30:15Z

1

Typo:

elements[i].innerHTMl should read elements[i].innerHTML (uppercase L)

answered Jul 10, 2017 at 17:30

grateful

1,13814 silver badges25 bronze badges

Comments

Araymer · Accepted Answer · 2017-07-10 17:36:07Z

0

You have a lowercase L in innerHTML...

Here's a working demo

    (function() {
    document.getElementById('btn').addEventListener('click', function(e) {
      e.preventDefault();
      getDivs();
    })
  })()

  function getDivs() {
    var elements = document.getElementsByTagName('div');
        console.log(elements);
    for (var i = 0; i < elements.length; i++) { 
        elements[i].innerHTML = "sometext" + i;
    }
  }

https://jsfiddle.net/h7cgmxmf/

answered Jul 10, 2017 at 17:36

Araymer

1,5451 gold badge12 silver badges16 bronze badges

Collectives™ on Stack Overflow

javascript: loop through elements and change their values [duplicate]

3 Answers 3

16 Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

16 Comments

Comments

Comments

Linked

Related