python : appending new data in xml is overring existing data

Question

i want to add entire tag to xml, below is my XML format.

<?xml version="1.0" encoding="UTF-8"?>
<ca st="true" name="XMLConfig">
    <app>
        <!---   I want to add entire commneted tag to XML . ! 
        <ar ty="co" name="st">    
            <ly ty="pt">
                 <pt>value</pt>
            </Layout>
        </ar>                    -->

        <roll name="roll" fN="file.log" fP="logs.gz">
            <ly type="ptl">
                 <pt>value</pt>
            </ly>
            <po>
    <!--            Comment /> -->
                <si size="100 MB" />
        <!--        Comment /> -->
            </po>
            <de fI="max" max="10"/>   
        </roll>       
    </app>

as shown in above file i want to add this tag in file

    <ar ty="co" name="st">    
        <ly ty="pt">
             <pt>value</pt>
        </Layout>
    </ar>

this is where i reached so far..

for appenders in tree.xpath('//Appenders'):
    if appenders.getchildren():
        appenders.remove(appenders.getchildren()[0])
        appenders.insert(0, appenders.getparent().append(etree.fromstring('<ar ty="co" name="st"> <ly ty="pt"><pt>value</pt></Layout></ar>')))

this is removing all other content after new content. any help will be appreciated.!

Arash Rohani · Accepted Answer · 2017-08-31 20:00:17Z

1

In my opinion the first way you did it is way better. You just made some mistakes in your insert line, it should be this:

appenders.insert(0, etree.fromstring('<ar ty="co" name="st"> <ly ty="pt"><pt>value</pt></ly></ar>')))

I'm surprised it didn't throw an error for you because your insert line is basically this:

appenders.insert(0,None)

Also I noticed you do something in all of your questions:

You leave out some line(s) of your xml file. (I mean why?)
You shorten the tag names in your xml but you keep their long version in the code, which is kind of annoying because the person who wants to answer you have to change the code again to see if it is working.

answered Aug 31, 2017 at 20:00

Arash Rohani

1,0321 gold badge10 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

tgcloud Over a year ago

Agreed, I went back and checked on this. the first method is working as it should. Thanks for the reply,! On 1st : because xml file has more than 200 lines .. and i think all those details are not needed. On 2nd : I will take care this from now onwords.. !

tgcloud Over a year ago

yes, the first way i did is giving me appenders.insert(0,None) and throwing exception. but i swear it was working for me before(removing all other content after new content). I think i messed up something while posting the code (I should not make changes in variable at all )

tgcloud · Accepted Answer · 2017-08-31 18:43:04Z

0

I got it working, !

for apps in tree.xpath('//app'):  
    if appenders.tag == 'app':
        appenders.insert(0, etree.SubElement(appenders, 'ar', ty="Co", name="st"))
        for appender in tree.xpath('//ar'):
            appender.insert(0, etree.SubElement(appender, 'ly', ty="pt"))
            for layout in tree.xpath('//ly'):
                layout.insert(0, etree.SubElement(layout, 'pt'))
                for pattern in tree.xpath('//pt'):
                    pattern.text = 'value'


tree.write(r'C:\value.xml', xml_declaration=True, encoding='UTF-8')

if anyone has better way to do this .. please let me know to so i can improve on this .!

answered Aug 31, 2017 at 18:43

tgcloud

8876 gold badges19 silver badges42 bronze badges

Collectives™ on Stack Overflow

python : appending new data in xml is overring existing data

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related