Program doesnt enter foreach loop

Question

This is my code:

private List<Picture> items;

public List<Picture> Items
{
    get
    {
        if (items == null)
        {
            items = new List<Picture>();
            items = this.LoadAllItems();
        }

        return items;
    }

    set
    {
        this.items = value;
    }
}

public List<Picture> GetItemsBySearch(string searchTerm, string fieldName)
{
    DataAccess dbcontext = new DataAccess();
    string internalfield = dbcontext.GetInternalFieldNameByDisplayName(fieldName);
    List<Picture> PictureHits = new List<Picture>();

    var data = from Picture item in this.Items
               where item.GetType().GetProperty(internalfield).GetValue(item, null).ToString().Contains(searchTerm)
               select item;  

    foreach (Picture item in data)
    {
        PictureHits.Add(item);
    }

    return PictureHits;
}

The data.Count contains 88 items but it does not enter a foreach loop.

Does the var not work within a foreach loop?

Picture is a class with some objects like filename, ID, etc.

This is what "data" contains so it contains 88 items doesnt it?

from Picture item in this.Items??? should be from item in this.Items — Rahul
– Rahul, Commented Sep 13, 2017 at 10:59
Just a remark: the line items = new List<Picture>(); in the getter is useless. You can just remove it. — Dennis_E
– Dennis_E, Commented Sep 13, 2017 at 11:00
"The data.Count contains 88 items" No, it shows that source contains 88 items, which is the original List, aka Items. Data has no Count property. — Dennis_E
– Dennis_E, Commented Sep 13, 2017 at 11:20
if I try PictureHits = data.ToList(); PictureHits Count is 0 Maybe my where is not working? — Julian
– Julian, Commented Sep 13, 2017 at 11:24

tym32167 · Accepted Answer · 2017-09-13 11:06:52Z

2

Problem might be in where condition

var data = from Picture item in this.Items
               where item.GetType().GetProperty(internalfield) // threre
                   .GetValue(item, null).ToString().Contains(searchTerm) // might bean issue
               select item;

try to comment it and repro. If foreach will work, then you have criteria which is filtered all your data.

answered Sep 13, 2017 at 11:06

tym32167

4,9012 gold badges32 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Program doesnt enter foreach loop

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related