if else construct issue in value attribute of html

Question

 public function getEmployeeId() {
        if (!isset($_SESSION["email"]) || !isset($_SESSION["passwrd"])) {
            header("Location:index.php");
            // Cannot Access this page without Login.
        }
        if (empty($_POST)){
            $_SESSION['ids'] = "";
            $query = mysqli_query($this->connection, "SELECT MAX(EmployeeId) AS EmployeeId FROM employees") or die("Query execution failed: " . mysqli_error());
            while ($row = $query->fetch_assoc()) {
                // Push the id to the array.
                $_SESSION['ids'] = $row["EmployeeId"];
            }
        }
    }

The above code snippet bring the latest registered employee ID from the database. ------------------------>--------------------

public function updateSalary(){
        if (!isset($_SESSION["email"]) || !isset($_SESSION["passwrd"])) {
            header("Location:index.php");
            // This code Snippet ensures that in order to access this page Employee needs to be Login.
        }
        $EmployeeID = (isset($_GET['EmployeeId']) ? $_GET['EmployeeId'] : '');
        $query = mysqli_query($this->connection, "SELECT * FROM salary WHERE EmployeeId= '" . $EmployeeID . "'") or die("Query execution failed: " . mysqli_error());
        while ($row = $query->fetch_assoc()){
            // Push the id to the array
            $_SESSION['eids'] = $row["EmployeeId"];
            $_SESSION['salry'] = $row["Salary"];
            if ($_SESSION['ids']) {
            $_SESSION['ids'] = "";
            }
        }

the above code snippet is my update function to update each record. And i have included both the above function in my html form at the top.

The Problem is that : As my insertion and updation form is same, so the session value which is in if statement is echoed in the text box , else part does not work even if session is unset in if part, What should i do ? See the below code

here is the value attribute :

 <td>
                   <input type="number" name="EmployeeId" placeholder="EmployeeId" value="<?php if (isset($_SESSION["ids"])){echo $id_salaries;}else{echo $emp_id;} ?>" id="EmployeeId" autocomplete="off" class="form-control" readonly>
                </td>

your session if ($_SESSION['ids']) seems to always be set even with empty value, and its comparison is checking if it only exists and is not valued, is not that the problem? — Jean Michél Marca
– Jean Michél Marca, Commented Sep 14, 2017 at 3:43
This is not unset $_SESSION['ids'] = ""; this is your assigning empty value to session . session unset should be unset($_SESSION['ids']) — JYoThI
– JYoThI, Commented Sep 14, 2017 at 3:46
Yes, the value is coming from database in textfield when i want to insert data , but when i want to update some data than the id is not coming in text field — Rajat
– Rajat, Commented Sep 14, 2017 at 3:46
Your code is vulnerable to SQL injection, you need to fix this. — Enstage
– Enstage, Commented Sep 14, 2017 at 3:47

JYoThI · Accepted Answer · 2017-09-14 03:49:11Z

1

This is not session unset $_SESSION['ids'] = ""; this is your assigning empty string value to session . session unset should be unset($_SESSION['ids'])

answered Sep 14, 2017 at 3:49

JYoThI

12.1k1 gold badge13 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

if else construct issue in value attribute of html

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related