Javascript only parsing the last element of array

Question

Having an issue where str.replace only works in the last element of my array here is the array:

["omao","carlton","judging"]

and here is my javascript function

function emoji(data){
	
	//console.log(data);

	
	$(".message-content").each(function(){
		var elem = $(this);
		var str = elem.html();
		//var res = str.replace(":hey", '<img draggable="false" class="emoji jumboable" alt="emoji" src="https://discordchat.com/api/omao.png">');
		for(var i = 0;i < data.length; i++){
			var res = str.replace(":"+data[i], '<img draggable="false" title="Added using the WLA Poor Mans Nitro" class="emoji jumboable" alt="emoji" src="https://discordchat.com/api/'+data[i]+'.png" />');
			elem.html(res);
		}
		
		
	});
	
}

When you run it, only :judging gets replaced by the image, :omao and :carlton is ignored. Ive tried every "solution" I could find but all with the same issue.

Don't forget to accept answers, seeing you have a zero acceptance rate, though you already asked more than 15+ answers — Icepickle
– Icepickle, Commented Oct 12, 2017 at 22:37

Icepickle · Accepted Answer · 2017-10-12 21:08:57Z

3

The problem you have is that you are repeating the replace on the original string, and not on the already changed string, which is why only the last iteration is the one that gets set

You can change it like so

var str = elem.html();
for(var i = 0;i < data.length; i++){
    str = str.replace(":"+data[i], '<img draggable="false" title="Added using the WLA Poor Mans Nitro" class="emoji jumboable" alt="emoji" src="https://discordchat.com/api/'+data[i]+'.png" />');
}
// and set it only once
elem.html(res);

answered Oct 12, 2017 at 21:08

Icepickle

12.8k3 gold badges38 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Gibs LeFleur Over a year ago

Wowo this was humiliating. Thanks so much, problem solved

StackSlave · Accepted Answer · 2017-10-12 21:16:48Z

0

Change

elem.html(res);

to

elem.append(res);

If running this multiple times (like .click()) you will want to put elem.empty() right before your .each().

answered Oct 12, 2017 at 21:16

StackSlave

10.6k2 gold badges20 silver badges35 bronze badges

1 Comment

Icepickle Over a year ago

from what I see, he problably has a html like :amao :carlton :judging (seeing he preloads the elements html content) And just wants to replace does strings inside the single element

Collectives™ on Stack Overflow

Javascript only parsing the last element of array

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related