How to store for each loop values in different variables

Question

Case:

I'm trying to create a object which expects 18 parameters, these parameters i want to obtain from a for each loop. How do i do this?

Code of class which expects 18 parameters:

public WaardeObjecten(string waardeNaam1, string waarde1, string waardeNaam2, string waarde2, string waardeNaam3, string waarde3, string waardeNaam4, string waarde4, string waardeNaam5, string waarde5, string waardeNaam6, string waarde6, string waardeNaam7, string waarde7, string waardeNaam8, string waarde8, string waardeNaam9, string waarde9)
{
    this.waardeNaam1 = waardeNaam1;
    this.waarde1 = waarde1;

    this.waardeNaam2 = waardeNaam2;
    this.waarde2 = waarde2;

    this.waardeNaam3 = waardeNaam3;
    this.waarde3 = waarde3;

    this.waardeNaam4 = waardeNaam4;
    this.waarde4 = waarde4;

    this.waardeNaam5 = waardeNaam5;
    this.waarde5 = waarde5;

    this.waardeNaam6 = waardeNaam6;
    this.waarde6 = waarde6;

    this.waardeNaam7 = waardeNaam7;
    this.waarde7 = waarde7;

    this.waardeNaam8 = waardeNaam8;
    this.waarde8 = waarde8;

    this.waardeNaam9 = waardeNaam9;
    this.waarde9 = waarde9;
}

Code i got so far to create a object and fill it:

foreach (Panel p in panels)
{
    //ALWAYS 9 * (2 values) panels.
    var selectedRadioButton = p.Controls.OfType<RadioButton>().FirstOrDefault(rb => rb.Checked);
    if (selectedRadioButton != null)
    {
        totalStringForRadioButtons += $"{selectedRadioButton.Name} : {selectedRadioButton.Text} | ";
    }
}

WaardeObjecten obj = new WaardeObjecten(**Expects 18 parameters here**);

For each for each result(9) i want to obtain : selectedRadioButton.Name and selectedRadioButton.Text(2) and put this 18 values in the object.

Ideally you would significantly refactor your code, but in this specific instance of code I would suggest you create a string array with length 18, fill it with your values during the loop, and then use that to supply the parameters to your function call — musefan
– musefan, Commented Oct 24, 2017 at 8:59

Geoffrey · Accepted Answer · 2017-10-24 09:09:38Z

1

As pointed out, you should refactor your code. Not only would this fix your problem, it will also make it more flexible in the future.

public class WaardePaar
{
    public string Naam { get; set; }
    public string Waarde { get; set; }
}

public WaardeObjecten(IEnumerable<WaardePaar> paren)
{
    // store in a private field list or array
    _values = paren.ToList();
}

Now you can just iterate over them or use an indexer to get specific values.

public WaardePaar this[int index]
{
    get { return _values[index]; }
    set { _values[index] = value; }
}

answered Oct 24, 2017 at 9:09

Geoffrey

9761 gold badge10 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Niels Over a year ago

I dont get this code, what code i should place in "WaardeObjecten"? and what code in my main class?

Geoffrey Over a year ago

Instead of keeping two arrays with matching indices, create an object that holds these two values (this is "WaardePaar"). In your main class you then simply store an array or List (here _values) that you can easily access with the indexer function. So if you implement the indexer in WaardeObjecten then you can basically call myWaardeObjectenInstance[4] to get the pair{ Naam, Waarde }

musefan · Accepted Answer · 2017-10-24 09:40:44Z

1

Overall it looks like you have problems with your design and should probably consider refactoring your code. However, that would be a bit too much to go into in an answer so I will stick with directly providing a solution to your current code.

I would suggest you use a string array to store your values, which you populate in your loop and then use that to supply the parameters to your function.

Declare and use the string array like so:

string[] values = new string[18];

int count = 0;
foreach (Panel p in panels)
{
    //ALWAYS 9 * (2 values) panels.
    var selectedRadioButton = p.Controls.OfType<RadioButton>().FirstOrDefault(rb => rb.Checked);
    if (selectedRadioButton != null)
    {
        values[count] = selectedRadioButton.Name;
        values[count+1] = selectedRadioButton.Text;
    }

    count+=2;
}

Now, you can call your function like this:

WaardeObjecten obj = new WaardeObjecten(values[0], values[1], values[2] /*etc.*/);

Alternatively, you could change your function to this:

public WaardeObjecten(params string[] values)
{
    this.waardeNaam1 = values[0];
    this.waarde1 = values[1];

    // etc.
}

And then just simplify the call:

WaardeObjecten obj = new WaardeObjecten(values);

edited Oct 24, 2017 at 9:40

answered Oct 24, 2017 at 9:35

musefan

48.5k21 gold badges144 silver badges193 bronze badges

5 Comments

Niels Over a year ago

Where do u get [i] from?

musefan Over a year ago

@Niels: Sorry, it was meant to be count. I was in "for loop auto-pilot mode"... fixed

Niels Over a year ago

i see, let me try.

Niels Over a year ago

How would you setup the waardeObjecten class?

musefan Over a year ago

@Niels: Sorry, it would be too much to go into detail in either a comment or an answer. Also, I don't have your class code anyway to be able to give an accurate review. But it seems you would be better have a list rather that 9 different sets of properties. Try to keep in mind, if you are naming something with a number, you are probably doing it wrong (though there are rare exceptions)

KulaDamian · Accepted Answer · 2017-10-24 10:02:26Z

0

A better alternative would be to store the data in the array and send it to the WaardeObjecten constructor. Like this:

public WaardeObjecten(string[] waardeNaam, string[] waarde)
{ //do the assignment here}

whereas in the foreach loop, you can add data in the string array:

int i = 0;
string waardenaam[9];
string waarde[9];
foreach (Panel p in panels)
{
     var selectedRadioButton = p.Controls.OfType<RadioButton>().FirstOrDefault(rb => rb.Checked);

     if (selectedRadioButton != null)
     {
           waardenaam[i] = selectedRadioButton.Name;
           waarde[i] = selectedRadioButton.Text;
     }
     i++;
}

WaardeObjecten obj = new WaardeObjecten(waardenaam, waarde);

edited Oct 24, 2017 at 10:02

answered Oct 24, 2017 at 9:04

KulaDamian

1443 silver badges14 bronze badges

8 Comments

Niels Over a year ago

Getting the error at [i]: "bad array declarator to declare a managed array the rank specifier precedes the variable's identifier" in this code.

KulaDamian Over a year ago

I just posted a rough code here to give you an idea as how to do it. Is your code in c++?

KulaDamian Over a year ago

Check the code now, the string arrays have to be initialized outside the loop.

Niels Over a year ago

It's in C#, there are probally better ways to get to the same point but I'm still learning.

musefan Over a year ago

@MubashiraZaman: First of all, the question is tagged with C# so you shouldn't need to ask (why you have mentioned Java at all is beyond me). Secondly, you should really test your code to make sure it work if you are not comfortable enough to post it from memory. Not only is your declaration syntax wrong, but you still haven't declared them outside the loop as you claim... you know the loop is the foreach part right?

|

Collectives™ on Stack Overflow

How to store for each loop values in different variables

3 Answers 3

2 Comments

5 Comments

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

5 Comments

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related