Php Variable not passing into whereHas function - Laravel Eloquent

Question

Summary: I cannot access the $domain variable in the whereHas function (below); Laravel returns the following error:

"Undefined variable: domain"

I am including my relationships because I am not sure if the nature of eloquent and how I am trying to call this query is causing problems.

I have a middleware that is calling a Model (Org)

Org model has field

subdomain

Org model has

public function domains()
{
    return $this->hasMany('App\Domain');
}

Domain model (tablename domains) has fields

domain, org_id

Also has function

public function org()
{
    return $this->belongsTo('App\Org');
}

I can dd($domain); before this function with no problems. however, the I am getting a

"Undefined variable: domain"

for the query parameter inside the whereHas function below.

Why can't laravel see the variable set above?

namespace App\Http\Middleware;
use Closure;
class DomainLookup
{

    protected $org;

    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure  $next
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        $route = $request->route();
        $domain = $route->parameter('domain');
        $trimmed_domain = trim($domain, (config('app.domain')));

        $this->org = \App\Org::where('subdomain',$trimmed_domain)
             ->whereHas('domains', function($q) {
                  $q->where('domain',  $domain);
              })
              ->get();

        if ($this->org) {
            return $next($request);
        }

    }


}

@Hackerman ... im still learning php, is that php behavior, or laravel magic? Re: function($q, $domain) .. vs .. function($q) use ($domain) — Nick
– Nick, Commented Mar 1, 2018 at 18:49
The second is laravel magic...the first one is good ol' php. — Hackerman
– Hackerman, Commented Mar 1, 2018 at 19:10

Laerte · Accepted Answer · 2018-02-05 20:01:57Z

9

You need to call use after function:

$this->org = \App\Org::where('subdomain',$trimmed_domain)
             ->whereHas('domains', function($q) use ($domain) {
                  $q->where('domain',  $domain);
              })
              ->get();

answered Feb 5, 2018 at 20:01

Laerte

7,0833 gold badges35 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jubin · Accepted Answer · 2018-02-05 20:05:28Z

2

You should pass the $domain to your closure with a use:

->whereHas('domains', function($q) use ($domain) {
    ...
});

answered Feb 5, 2018 at 20:05

Jubin

511 silver badge7 bronze badges

Collectives™ on Stack Overflow

Php Variable not passing into whereHas function - Laravel Eloquent

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related