else part not working in bash while read loop

Question

In bash coding,

What to do is that if the grep size is less than 800MB i want to ignore but if grep size is more than 800MB, i want to print that path in file xyz/symlinks_paths.txt. but problem coming in else statement. Can you help me, i want to print that path whose size is more than 800MB in xyz/size_list.txt file. Also, line3 is a directory path.

while
    read -r line3
        do
            if [[ "ls -lh $line3 | grep zzz.exe | grep '[8-9][0-9][0-9][MG]'" = " " ]] 
                then break
                else line3 >> xyz/size_list.txt
            fi
        done < xyz/symlinks_paths.txt

No, the error says, line3 is a directory OR line3 command not found, that means after break it is in if loop only. — Pompy
– Pompy, Commented Feb 19, 2018 at 14:43
Maybe you should try with find, which lists all your symlinks and can even give you the information on sizes for found files. — Stefan M
– Stefan M, Commented Feb 19, 2018 at 14:49
No Stefan, i dont want to use find command, because i have to run this on huge database, which will take days on find. — Pompy
– Pompy, Commented Feb 19, 2018 at 14:53

Stefan M · Accepted Answer · 2018-02-19 14:48:37Z

1

You really shouldn't parse ls.

On the other hand, you're exiting your while-loop with the break statement. Maybe you can negate your if-condition, so that you can put your else-Part into the then part.

What were you trying to achieve by this line:

line3 >> xyz/size_list.txt

Do you want to append the contents of ${line3} into the file? Than this should work:

echo "${line3}" >> xyz/size_list.txt

edited Feb 19, 2018 at 14:48

answered Feb 19, 2018 at 14:42

Stefan M

8847 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Pompy Over a year ago

how to negate this if loop?

Stefan M Over a year ago

With a !. See for example this answer to Negate if condition in bash script.

sahaquiel · Accepted Answer · 2018-02-19 14:49:23Z

1

Imho, it's better (and more readable) to do like that:

#!/bin/bash

while
    read -r line3
        do
            #819200 kbytes = 800 Mbytes. Echo in file if the size greater or equal
            if [ $(du -s "${line3}/zzz.exe" | awk '{print $1}') -ge 819200 ]
            then 
                echo "${line3}" >> xyz/size_list.txt
            fi
        done < xyz/symlinks_paths.txt

answered Feb 19, 2018 at 14:49

sahaquiel

1,83811 silver badges23 bronze badges

4 Comments

Pompy Over a year ago

Using ${line3} , still says that line3 is a directory. :(

sahaquiel Over a year ago

@Pompy well..can you show me that variable value in your code?

Pompy Over a year ago

/prj/pika/BMX/pikatree/1504729073xz-dir/pulser

Pompy Over a year ago

sorry viktor, i forgot the echo. my bad. :)

Collectives™ on Stack Overflow

else part not working in bash while read loop

2 Answers 2

2 Comments

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related