regex value is not matching jquery

Question

I am trying to match clicked linked path with other links. It does not work at all. Here's the code. I need to link's href starts with the regex.

 $('#taxonomylist ul li a').click(function() {
        $href = $(this).attr("href");
        $regex = new RegExp("^"+$href);
        $('#taxonomylist ul li').each(function() {
        $href_sub = $("a", this).attr("href");
        if ($href_sub.match($regex))
        {
        $(this).css("display", "block");
        }

       });
       return false;
        });

Here's what I got in firebug:

$href = "/?q=category/activity/test"  
$href_sub = "/?q=category/activity/test/lamp"  
$regex = /^\/?q=category\/activity\/test/

Everything seems find, but it does not work as expected. If I remove matching by regex, everything works fine (without filtering, of course).

EDIT:

Now it partially works, only assign css property to all links, not only those that match value. Does anyone see the problem?

$('#taxonomylist ul li a').click(function() {
$href = $(this).attr("href");
$regex = new RegExp("^"+$href);
$('#taxonomylist ul li').each(function() {
$href_sub = $("a", this).attr("href");
if ('$href_sub:contains($href)')
{
$(this).css("display", "block");
}

});
return false;
});

if all you're doing is matching the beginning of the value, regex is overkill. use .indexOf instead. — Brad Christie
– Brad Christie, Commented Feb 4, 2011 at 5:52

Ruel · Accepted Answer · 2011-02-04 06:03:01Z

2

Because you're asking if the regex matches your string. Meaning, your regex should at least look like this (based on your example):

$regex = /^\/?q=category\/activity\/test\/\w+/

You might want to use :contains() selector instead.

edited Feb 4, 2011 at 6:03

answered Feb 4, 2011 at 5:54

Ruel

15.8k7 gold badges41 silver badges49 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user194076 Over a year ago

Thanks! This solves problem partially. I cannot find an error. When I click a link, all other links are getting displayed, not only that are matched pattern. Do you see an error? Code is at the top of the page

Community · Accepted Answer · 2020-06-20 09:12:55Z

1

check this

use indexOf(//value to search) for matching

hope it helps

edited Jun 20, 2020 at 9:12

CommunityBot

11 silver badge

answered Feb 4, 2011 at 7:16

Rafay

31.1k5 gold badges71 silver badges106 bronze badges

2 Comments

user194076 Over a year ago

it does not work. Still shows all things. Just does not run correctly. See: jsfiddle.net/yNJKj/4

user194076 Over a year ago

Thank you so much. It finally works! I really appreciate this.

Collectives™ on Stack Overflow

regex value is not matching jquery

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related