Passing installer arguments as index of array

Question

I'm trying to pass arguments to a MSI installer:

$Servers = @("ServerOne", "ServerTwo", "ServerThree")

$InstallerArguments = @(
    "/i `"$InstallerPath`"",
    "/quiet",
    "/log `"$LogFile`"",
    "EMAILSERVER=`"$Servers[0]`"",
    "DATABASESERVER=`"$Servers[1]`"",
    "SHAREPOINTSERVER=`"$Servers[2]`"",
    "USERNAME=`"$UserName`""
)

Reviewing the installer logfile shows the result:

Property(S): EMAILSERVER = ServerOne ServerTwo ServerThree[0]
Property(S): DATABASESERVER = ServerOne ServerTwo ServerThree[0]

Expected result:

Property(S): EMAILSERVER = ServerOne

I think I need to escape the index somehow, what is wrong with the code?

Edit (passing arguments to installer):

Start-Process -FilePath msiexec.exe -ArgumentList $InstallerArguments -Wait

How are you actually passing that to the installer? Show us the code that actually calls the MSI. — EBGreen
– EBGreen, Commented Mar 20, 2018 at 18:11
@EBGreen I've edited the post. Also added a single argument $Username which is correct. The issue is passing array elements. — LightningWar
– LightningWar, Commented Mar 20, 2018 at 18:25

Bill_Stewart · Accepted Answer · 2018-03-20 18:59:34Z

1

The subexpression operator - $() - is one way you can embed an array element (or the output of an arbitrary expression) within a string:

$Servers = @("ServerOne", "ServerTwo", "ServerThree")

$InstallerArguments = @(
  "/i ""$InstallerPath"""
  "/quiet"
  "/log ""$LogFile"""
  "EMAILSERVER=""$($Servers[0])"""
  "DATABASESERVER=""$($Servers[1])"""
  "SHAREPOINTSERVER=""$($Servers[2])"""
  "USERNAME=""$UserName"""
)

Start-Process msiexec.exe $InstallerArguments -Wait

The subexpression operator is documented in the about_Operators help topic.

For an even more readable array, you can use the -f string formatting operator and single-quotes; example:

$InstallerArguments = @(
  ('/i "{0}"' -f $InstallerPath)
  '/quiet'
  ('/log "{0}"' -f $LogFile)
  ('EMAILSERVER="{0}"' -f $Servers[0])
  ('DATABASESERVER="{0}"' -f $Servers[1])
  ('SHAREPOINTSERVER="{0}"' -f $Servers[2])
  ('USERNAME="{0}"' -f $UserName)
)

edited Mar 20, 2018 at 18:59

answered Mar 20, 2018 at 18:33

Bill_Stewart

24.9k5 gold badges55 silver badges70 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

UnhandledExcepSean · Accepted Answer · 2018-03-20 18:31:43Z

0

This does exactly what you want. I presume you did want the quotes.

$Servers = @("ServerOne", "ServerTwo", "ServerThree")

$InstallerArguments = @(
    "/i `"$InstallerPath`"",
    "/quiet",
    "/log `"$LogFile`"",
    "EMAILSERVER=`"$($Servers[0])`"",
    "DATABASESERVER=`"$($Servers[1])`"",
    "SHAREPOINTSERVER=`"$($Servers[2])`"",
    "USERNAME=`"$UserName`""
)

answered Mar 20, 2018 at 18:31

UnhandledExcepSean

12.9k4 gold badges38 silver badges54 bronze badges

Comments

vrdse · Accepted Answer · 2018-03-20 18:47:15Z

If you use ", PowerShell will recognize variables and replace them with their content. If it's an array, the elements will be joined by $OFS.

If you want to specify properties, elements, etc. you have to use $() to make shure, PowerShell understand that this is part of the variable (e.g. $($Servers[0]).

If you need in addition " inside a string, I recommend to work with ' (which does not replace variables) and the -f operator.

'EMAILSERVER="{0}"' -f $Servers[0]

Also there is no need for all those arrays.

$InstallerPath = 'C:\'
$LogPath = 'D:\'
$MailServer = 'mail'

$InstallerArguments = '/i "{0}" /quiet /log "{1}" EMAILSERVER="{2}"' -f $InstallerPath, $LogPath, $MailServer

Start-Process -FilePath msiexec.exe -ArgumentList $InstallerArguments -Wait

I think that's much more readable.

EBGreen · Accepted Answer · 2018-03-20 18:48:05Z

0

So much unneeded complexity with the array. This should work:

$Servers = @("ServerOne", "ServerTwo", "ServerThree")
$args = '/i "{0}" /quiet /log "{1}" EMAILSERVER={2} DATABASESERVER={3} SHAREPOINTSERVER={4} USERNAME={5}' -f $InstallerPath, $LogFile, $servers[0], $servers[1], $servers[2], $username
Start-Process msiexec.exe $args

edited Mar 20, 2018 at 18:48

answered Mar 20, 2018 at 18:38

EBGreen

38k12 gold badges69 silver badges86 bronze badges

5 Comments

EBGreen Over a year ago

Aaah yes. I will replace hash with array and my comment stands. :)

Bill_Stewart Over a year ago

The array may be to keep from having a single extremely long string to edit, and to make it easier to insert other needed parameters. The sticky point, as I understand the original question, was how to embed an array element within a string; my answer and another shows one way using the $() (subexpression) operator.

EBGreen Over a year ago

I understand why someone would do it this way. I just feel it is trading complexity for scrolling. Just an opinion I prefer a nice clean string formatter built string even if I have to scroll a little.

Bill_Stewart Over a year ago

I like this also, and updated my array answer with -f (middle-ground approach) -- although I would recommend quoting the MSI property values in your example (in case any contain whitespace).

EBGreen Over a year ago

I did quote paths. I wouldn't consider it likely that server names or user names would have spaces but certainly quote whatever makes you happy.

Collectives™ on Stack Overflow

Passing installer arguments as index of array

4 Answers 4

Comments

Comments

Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related