SQL query INSERT not working inserting values into my DB

Question

I'm trying to insert registration data into a database but my php code isn't inserting the values into the DB although I'm not getting any errors either, can someone help me? this is the code i'm currently using:

$connect = mysql_connect("localhost","myusername","mypassword");
mysql_select_db("application");

$queryreg = mysql_query('INSERT INTO users("username","password","email","date") VALUES("$username","$password","$email","$date")');

die ("You Have Been Registered.");

I just need to add the username password email and date into the fields i have specified but it won't work, please someone help!

In PHP, variables don't get resolved in single quote strings. They do in double quote strings. So as noted below, you can do it with single quotes and . operators, or do it with double quotes and escape all quotes within your code. — Adam Casey
– Adam Casey, Commented Feb 9, 2011 at 15:24

Haim Evgi · Accepted Answer · 2011-02-09 15:21:32Z

1

change this line

 $queryreg = mysql_query("INSERT INTO users(username,password,email,date)
 VALUES('".$username."','".$password."','".$email."','".$date."')");

check error

if (mysql_errno()) { 
    die('Invalid query: ' . mysql_error());
}

answered Feb 9, 2011 at 15:21

Haim Evgi

126k46 gold badges222 silver badges226 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

Aiden Ryan Over a year ago

I've done that but it still isn't inserting the data into the DB ):

Aiden Ryan Over a year ago

Yeah ;o "Column count doesn't match value count at row 1"

Aiden Ryan Over a year ago

The fields in my database are "id username password email joined admin vip" if that helped

Haim Evgi Over a year ago

in the table users, do you have more fields , mandatory (could not be null)

Haim Evgi Over a year ago

can you publish the create table

|

bamana · Accepted Answer · 2011-02-09 15:26:29Z

Here is a good reference for connecting and doing an insert into a database using PHP and MySQL W3Schools PHP MySQL Insert. From the looks of it you need to remove the "s around username, password, email and date like Haim Evgi mentioned. Also I would try closing the connection if you are finished with it. Here is a code sample from the site:

$con = mysql_connect("localhost","peter","abc123");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }

mysql_select_db("my_db", $con);

mysql_query("INSERT INTO Persons (FirstName, LastName, Age)
VALUES ('Peter', 'Griffin', '35')");

mysql_query("INSERT INTO Persons (FirstName, LastName, Age) 
VALUES ('Glenn', 'Quagmire', '33')");

mysql_close($con);

Collectives™ on Stack Overflow

SQL query INSERT not working inserting values into my DB

2 Answers 2

9 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

9 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related