PHP won't update +1 value on mysql

Question

$sql="UPDATE users SET TN4='1', Notificare4='1', Neachitate='1' WHERE username='$user'";

This works fine. It sets Neachitate row into 1. But, I want to set it to $Neachitate+ 1 ( +1 value, like each time you click it adds one more)

So, I modified it with

$Neachitate = $row['Neachitate']; // it gets what value is in Neachitate, right?

    $sql3="UPDATE users SET TN4='1', Notificare4='1', Neachitate='$Neachitate + 1' WHERE username='$user'";

But this time it sets to 0. Why?

Federkun · Accepted Answer · 2018-04-01 12:13:09Z

1

Use

$sql3="UPDATE users SET TN4='1', Notificare4='1', Neachitate=Neachitate + 1 WHERE username='$user'";

instead.

You're trying to save Neachitate='$Neachitate + 1': this is a string, not a number.

answered Apr 1, 2018 at 12:13

Federkun

37.2k8 gold badges82 silver badges93 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Gordon Linoff · Accepted Answer · 2018-04-01 12:18:37Z

1

More generally, eliminate the single quotes! And use parameters!

UPDATE users
    SET TN4 = 1,
        Notificare4 = 1,
        Neachitate = ? + 1
    WHERE username = ?;

Single quotes should only be used for string and date constants. Parameters should always be used for passing constant values into queries.

answered Apr 1, 2018 at 12:18

Gordon Linoff

1.3m62 gold badges706 silver badges857 bronze badges

1 Comment

Emin Eryilmaz Over a year ago

thank you for your time and explications. I'll learn better from stackoverfllow than any school / studies. Yeah, if only I wouldn't get downvotes because I don't understand something and asking it (even if I read something close to my question and still don't get it.)

Collectives™ on Stack Overflow

PHP won't update +1 value on mysql

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related