Calling ES6 class constructor from class static method

Question

I'm trying to do my implementation of singleton pattern in JS ES6 class. Here is what I wrote so far:

let instance;

export class TestClass{

    constructor(){
        if(new.target){
            throw new Error(`Can't create instance of singleton class with new keyword. Use getInstance() static method instead`);
        }
    }
    testMethod(){
        console.log('test');
    }
    static getInstance(){
        if(!instance) {
            instance = TestClass.constructor();
        }

        return instance;
    }
}

However, when I call static method TestClass.getInstance(), I'm not getting instance of class object, I'm getting

ƒ anonymous() {

}

function, without access to testMethod. I can't find error in my code - help will be greatly appreciated.

I don't want to use new keyword, that's why I throw error in constructor if it was called with usage of "new". @JonasW. Yes I know, simplest singleton is simple JS object {}. I want to use ES6 classes. — Furman
– Furman, Commented Apr 15, 2018 at 20:34
Just don't export the class. Only export the getInstance() function that does what you want. Or, perhaps even better, just create and export the singleton, that's all. One call still call all the methods on the singleton even though you didn't export the class itself. — jfriend00
– jfriend00, Commented Apr 15, 2018 at 20:39
I don't want to use new keyword , then just export an object and not the class. export new TestClass() , also if your doing this for lazy construction, then export a wrapper function to export the object. — Keith
– Keith, Commented Apr 15, 2018 at 20:53

Bergi · Accepted Answer · 2020-07-25 21:56:37Z

7

TestClass is the constructor function. TestClass.constructor is the builtin Function, which when called constructs a new empty function (what you are logging).

The TestClass constructor can also be accessed as TestClass.prototype.constructor, that's what you probably meant:

static getInstance(){
    if (!instance) {
        instance = TestClass.prototype.constructor();
    }
    return instance;
}

This will of course throw an exception that you cannot call class constructors without new.

You also should simplify to new TestClass. Or even better, in case you want to support subclassing, new this - notice that this in static method refers to the class (constructor) itself.

I'm trying to do my implementation of singleton pattern in JS ES6 class

Please don't. Singletons are bad practice. If your class doesn't have any state, and there's just one instance anyway, don't use a class. Just write

export function testMethod() {
    console.log('test');
}
// Yes, that's the whole file!

If you insist on lazily constructing the module, I would recommend

let instance;
/*default*/ export function getInstance() {
    return instance || (instance = { // use a simple object literal
        testMethod(){
            console.log('test');
        }
    });
}

That said, if you insist on making a "private" constructor I would pass a token:

const internal = Symbol("creation token for TestClass");
export class TestClass {
    constructor(token) {
        if(token !== internal) {
            throw new Error("Please use the TestClass.getInstance() static method instead");
        }
    }
    …
    static getInstance(){
        return new TestClass(internal); // make sure not to call `this`, otherwise subclassing could leak the token
    }
}

But you should never really need that.

edited Jul 25, 2020 at 21:56

answered Apr 15, 2018 at 20:34

Bergi

671k162 gold badges1k silver badges1.5k bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Furman Over a year ago

So it's not possible to create ES6 class object without using "new" keyword?

Furman Over a year ago

That's a very nice trick with this Symbol token - thank you for detailed answer.

jfriend00 Over a year ago

Why even export the class at all? Why not just export a factory function that returns the singleton. Then, the constructor can just be a normal constructor that is only used within the module to create the original singleton. The public calls the factory function which always returns the singleton.

Furman Over a year ago

Yes I know there are many different ways to achieve similiar effect. ES6 singleton implementation was done for educational purposes only.

Bergi Over a year ago

@jfriend00 normal constructor doesn't work, as otherwise anyone could do new (getInstance().constructor). But yeah, whether getInstance is exported or the whole class doesn't make much of a difference (same for other static methods).

|

Dan D · Accepted Answer · 2018-04-15 20:36:06Z

1

You haven't created an instance of the TestClass, you've just assigned your instance variable as the constructor function of the TestClass.

I typically would create the singleton like this if I need to:

class TestClass {
  constructor() {

  }

  testMethod() {

  }
}

const instance = new TestClass();

export default instance;

answered Apr 15, 2018 at 20:36

Dan D

2,53318 silver badges23 bronze badges

Comments

CertainPerformance · Accepted Answer · 2018-04-15 20:46:48Z

1

The problem is that ES6 Class constructors cannot be invoked without 'new' - your new.target test is superfluous. If you want to keep your Class syntax, you could do something like the following to ensure that only your module has the ability to create the class:

let instance;
let creating = false;
class TestClass{
  constructor(key) {
    if(!creating) {
      throw new Error(`Can't create instance of singleton class with new keyword. Use getInstance() static method instead`);
    }
  }
  testMethod() {
    console.log('test');
  }
  static getInstance() {
    if(!instance) {
      creating = true;
      instance = new TestClass();
      creating = false;
    }
    return instance;
  }
}

const theInst = TestClass.getInstance();
theInst.testMethod();

edited Apr 15, 2018 at 20:46

answered Apr 15, 2018 at 20:38

CertainPerformance

373k55 gold badges354 silver badges359 bronze badges

Collectives™ on Stack Overflow

Calling ES6 class constructor from class static method

3 Answers 3

8 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

8 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related