node.js blocking, non-blocking issue in for statement

Question

How can I save all of the json into my mongoldb? Strangely, only the first value is stored every time. It might be blocking/non-blocking issue.

json = {
  ["name":"Karl","id":"azo0"],
  ["name":"Robert","id":"bdd10"],
  ["name":"Joan","id":"difj90"],
  ["name":"Hallyn","id":"fmak88"],
  ["name":"Michael","id":"vma91"]
};

for(var i = 0; i < json.length; i++){
  id = json[i].id;
  name = json[i].name;

  var ctx = {"id":id,"name":name};
  db.json_db.count(ctx).exec(function(err, count) {
    if(count < 1){
        var model = new User({
           "name":json[i].name,
           "id":json[i].id
        });
        model.save(function(){
            console.log("ok"+i);

        });
    }
  });
};

After inserting, all of datas are filled with ["name":"Karl","id":"azo0"] To check out console.log("ok"+i), it prints always "ok0" not "ok1", "ok2", "ok3"... etc..

How can I prevent this issue?

FWIW: There is only one variable called i in the code: the same variable is accessed from each distinct closure. That said, I'd expect it to print "ok*5*" if it's truly asynchronous.. — user2864740
– user2864740, Commented May 12, 2018 at 1:25
See stackoverflow.com/questions/750486/… ; also, ES-6 has let, see stackoverflow.com/questions/41892488/closures-versus-es6-let — user2864740
– user2864740, Commented May 12, 2018 at 1:28

Truong Dang · Accepted Answer · 2018-05-12 04:44:34Z

1

Incase you're using Async package, this is an best way to solve your problem...

  async.eachSeries(json, (item, done) => {
   let user = new User(
                     {
                        "name":json[i].name,
                         "id":json[i].id
                    },
                    (err, user) => {
                        if(err){
                           // handle err
                        }
                        return done();
                    }
                );
});

answered May 12, 2018 at 4:44

Truong Dang

3,4771 gold badge17 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Cisco · Accepted Answer · 2018-05-12 04:20:41Z

1

.exec() tells me you're using Mongoose. So your loop can rewritten as:

const json = [
  {name: "Karl", id: "azo0"},
  {name: "Robert", id: "bdd10"},
  {name: "Joan", id: "difj90"},
  {name: "Hallyn", id: "fmak88"},
  {name: "Michael", id: "vma91"}
];

for (const item of json) {
  const count = await db.json_db.count(item).exec()
  if (!count) {
    await new User(item).save()
  }
}

Error handling omitted.
See http://exploringjs.com/es2016-es2017/ch_async-functions.html

answered May 12, 2018 at 4:20

Cisco

23.5k6 gold badges44 silver badges67 bronze badges

1 Comment

Richard Over a year ago

Thank you Mateo, Maybe that’s because everyone is basically used "var" instead of "let", "const". Thanks to you I can resolve my case :)

Collectives™ on Stack Overflow

node.js blocking, non-blocking issue in for statement

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related