HTML embed video using PHP variable doesn't work

Question

I'm trying to display all videos a webpage using the following code, I've gotten as far as being able to iterate over the files, printing the file names and embedding a video. However the videos are greyed out and don't work, I suspect I did something wrong with using $filename in the code.

<?php
$dir = new DirectoryIterator(dirname(__FILE__));
foreach ($dir as $filename) {
    if (!$filename->isDot()) {

        if ($filename != "index.php" and $filename != "error_log") {

            echo $filename, "<br>"; 

            echo '<video width="400" controls="controls" preload="metadata">
            <source src=$filename type="video/mp4"></video>';

            echo "<br><br>";
        }

    }
}
?>

This is how it shows up:

use double quotes instead: echo "<video width='400' controls='controls' preload='metadata'><source src=$filename type='video/mp4'></video>"; — keaton
– keaton, Commented May 12, 2018 at 14:32

Gandalf the Gay · Accepted Answer · 2018-05-12 14:44:34Z

2

Hi

You are echo $filename like a string, not a PHP variable.

Remember, if echo with single quotes ' all inside it will echo like string and echo with double quotes " will echo PHP variables reading their value. Informations about strings in PHP are nicley explained e.g. here .

You can change your piece of code witch echo HTML video to:

echo '<video width="400" controls="controls" preload="metadata"><source src="' . $filename . '" type="video/mp4"></video>';

Note that there were also missing double quotes for HTML video tag src property and I added them in code above.

Cheers

edited May 12, 2018 at 14:44

answered May 12, 2018 at 14:31

Gandalf the Gay

4302 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

RiggsFolly · Accepted Answer · 2018-05-12 14:34:02Z

1

Change

<source src=$filename type="video/mp4"></video>';

to

<source src="'.$filename.'" type="video/mp4"></video>';

edited May 12, 2018 at 14:34

RiggsFolly

94.7k22 gold badges108 silver badges152 bronze badges

answered May 12, 2018 at 14:31

Saypontigohe

3111 gold badge2 silver badges15 bronze badges

Comments

The fourth bird · Accepted Answer · 2018-05-12 15:02:47Z

1

Your php variable is inside single quotes and (from the doc) variables and escape sequences for special characters will not be expanded when they occur in single quoted strings.

As an alternative you could keep your string between single quotes and make use of sprintf which will return a formatted string and use for example %s to specify that the argument should be handled as string type.

echo sprintf('<video width="400" controls="controls" preload="metadata">
<source src="%s" type="video/mp4"></video>',
    $filename);

answered May 12, 2018 at 15:02

The fourth bird

165k16 gold badges61 silver badges75 bronze badges

Collectives™ on Stack Overflow

HTML embed video using PHP variable doesn't work

3 Answers 3

Hi

Cheers

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Hi

Cheers

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related