Why function variable returns wrong calculation?

Question

I'm having an issue with accuracy of my code.
I made a function to calculate the Fibonacci series:

  function fibonacciseries(max_number, p, n) {
    if(p === undefined) { p = 0;}
    if(n === undefined) { n = 1;}
    if(n > max_number) { return 0; }
    console.log(n);
    return fibonacciseries(max_number, n, n + p)
    }
 fibonacciseries(3)

but when I run this code, console.log(n); shows:

I think result should be 1 1 2, so I really cannot understand why such a thing happens. Running fibonacciseries(4) & fibonacciseries(5) are OK, so what is wrong in the case of fibonacciseries(3) ? How should I fix this ?

You're testing n > max_number. Did you mean n >= max_number to exclude max_number from the logged list? — CertainPerformance
– CertainPerformance, Commented Jun 10, 2018 at 9:29
I get the impression you intend for max_number to be a count of how many numbers the function should log, but what it is actually doing is logging all Fibonacci numbers less than or equal to max_number. That is, fibonacciseries(20) doesn't log 20 numbers, it logs all Fibonacci numbers that are less than or equal to 20. — nnnnnn
– nnnnnn, Commented Jun 10, 2018 at 10:16

AA Shakil · Accepted Answer · 2018-06-10 09:53:28Z

1

check the n>=max_number not n>max_number. Try the below updated code

function fibonacciseries(max_number, p, n) {
    if(p === undefined) { p = 0;}
    if(n === undefined) { n = 1;}
    if(n >= max_number) { return 0; }
    console.log(n);
    return fibonacciseries(max_number, n, n + p)
    }
 fibonacciseries(3)

edited Jun 10, 2018 at 9:53

AA Shakil

5564 silver badges16 bronze badges

answered Jun 10, 2018 at 9:37

Beginner

9,20011 gold badges50 silver badges94 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user7523656 Over a year ago

thank you for your answer.When I run the codes fibonacciseries(5),only 1 1 2 3 is shown.What is wrong??

nnnnnn · Accepted Answer · 2018-06-10 10:27:01Z

You seem to want max_number to be a count of how many numbers the function should log, but what it is actually doing is logging all Fibonacci numbers less than or equal to max_number. That is, fibonacciseries(20) doesn't log 20 numbers, it logs all Fibonacci numbers that are less than or equal to 20. It's just a coincidence that fibonacciseries(4) & fibonacciseries(5) happen to produce the same result either way.

To fix this, don't compare max_number to n, just decrement max_number on each call and stop when it gets to zero. To make this a bit clearer I suggest renaming that argument:

function fibonacciseries(count, p, n) {
  if(p === undefined) { p = 0;}
  if(n === undefined) { n = 1;}
  if(count <= 0) { return 0; }
  console.log(n);
  return fibonacciseries(count - 1, n, n + p)
}

console.log("Count of 3:");
fibonacciseries(3);
console.log("Count of 5:");
fibonacciseries(5);
console.log("Count of 7:");
fibonacciseries(7);

Collectives™ on Stack Overflow

Why function variable returns wrong calculation?

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related