Creating an HTML table in Java

Question

I have a problem in my code when I am creating a table in Java using HTML. This is my code:

for(int station : stations){
   String rowcolor = null;
   String stationnum = Integer.toString(station);
   String lastDate = pollData(station); //CALL GET LAST 
   String status = determineStatus(station, lastDate); // CALL DETERMINE STATUS

    switch(status){
       case " ONLINE":
           rowcolor = (" <tr bgcolor=\"#5FFF33\">");
           break;
       case " OFFLINE":
           rowcolor = (" <tr bgcolor=\"red\">");
           break;
       case " DELAYED":
           rowcolor = (" <tr bgcolor=\"yellow\">");
           break;
   }

    out.write("<html>" +
       "<body>" +
       "<table border ='1'>" +
       "<tr>" +
       "<td>Station Number</td>" +
       "<td>Station Name</td>" +
       "<td>Status</td>" +
       "<td>As of Date</td>" +
       "</tr>");

    out.write(rowcolor + "<td>");
    out.write(stationnum);
    out.write("</td><td>");
    out.write(stationnname[id]);
    out.write("</td><td>");
    out.write(status);
    out.write("</td><td>");
    out.write(lastDate);
    out.write("</table>" +
       "</body>" +
       "</html>"); 
     id++; 
    out.close(); 
   }   

   }catch (IOException e) {
   System.err.println(e);
   }

and this is the output:

When I remove the out.close(); part, the output is this:

As you can see, the image there is a problem in creating the table. Something is not right but I can’t find a way to fix it. Please help me; thanks in advance.

Look at the generated HTML as source. I think you'll quickly see the problem — Phil
– Phil, Commented Jul 13, 2018 at 3:03
i want to contine the table just like in image one but it stops. so when i remove the out.close(); part it will get all the stations but it displays it one by one... — Carl
– Carl, Commented Jul 13, 2018 at 3:08
Yes, I know what you want to do. Have you looked at the generated HTML source code yet? — Phil
– Phil, Commented Jul 13, 2018 at 3:11

Phil · Accepted Answer · 2018-07-13 03:20:15Z

4

Look at what you're writing to the output buffer and where.

Inside your for loop, you are writing a complete HTML document (ie <html><body>...</body></html>) and an entire table with header row and one data row.

What I assume you want to do is keep writing table rows to the one table. To do so, write the aforementioned tags outside your for loop

out.write("<html><body><table border=\"1\"><thead>" +
        "<tr><td>Station Number</td><td>Station Name</td>" +
        "<td>Status</td><td>As of Date</td></tr></thead><tbody>");
for(int station : stations) {
    // get data, determine rowcolor, etc
    out.write(rowcolor + ... + "</tr>");
}

out.write("</tbody></table></body></html>");
out.close();

answered Jul 13, 2018 at 3:20

Phil

166k25 gold badges265 silver badges269 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

flyingfox · Accepted Answer · 2018-07-13 03:13:10Z

1

As Phil said,out.close(); is inside the for loop,you need to change it to outside the for loop,due to if it's inside loop,out will close for the first iterate,and will not work for other records

for(int station : stations){

}
out.close();

edited Jul 13, 2018 at 3:13

answered Jul 13, 2018 at 3:07

flyingfox

13.5k4 gold badges30 silver badges43 bronze badges

4 Comments

Phil Over a year ago

It's not the only thing in the loop that shouldn't be there

flyingfox Over a year ago

@Phil,yeah,that's not the only issue,but this issue is the most serious

Carl Over a year ago

i put the out.close(); part outside but still the same output like in image 2

Carl Over a year ago

@Phill i followed your instructions and it worked for me now. thank you

Collectives™ on Stack Overflow

Creating an HTML table in Java

2 Answers 2

Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related