While loop and if/else statement not working correctly

Question

The issue I am running into is that when I run the code, it adds correctly but when it comes time to run the if or else statement, nothing happens. It always just ends.

#include <iostream>
using namespace std;

int main()
{
   int firstNumber;
   int secondNumber;
   int sum;
   char restart = 1;

   while (restart == 1)
   {
      cout<<"Welcome to My Calculator!\n\n";
      cout<<"What is the first number you would like to add?\n\n";

      cin>>firstNumber;

      cout<<"What is the second number you would like to add?\n\n";

      cin>>secondNumber;

      cout<<"Wonderful! Getting together your result now....\n\n";
      sum = firstNumber +   secondNumber;
      cout<< sum<<endl;

      cout<<"If you have another question, just enter 1, if not press 2!\n\n";

      cin>>restart;
      if (restart == 1)
      {
         cout<<"No problem!\n\n";

      }
      else
      {

         cout<<"Goodbye!";
      }


   }
   return 0;
}

Even if you are using int for restart, condition for exit should be restart=0. Numbers other than zeroes are considered true. — Suhail Akhtar
– Suhail Akhtar, Commented Jul 17, 2018 at 5:42

resueman · Accepted Answer · 2018-07-16 23:48:07Z

4

char restart = 1;
if (restart == 1)

needs to be

char restart = '1';
if(restart == '1')

There is a difference between 1 and '1'. When you want to compare chars you use the '' marks.

Also, you should also always initialize your ints

This is because C++ doesn't automatically set it to zero for you. So, you should initialize it yourself:

int sum = 0;

An uninitialized variable has a random number such as 654654,-5454, etc. (If it doesn't invoke undefined behavior when reading it)

edited Jul 16, 2018 at 23:48

resueman

10.7k10 gold badges34 silver badges46 bronze badges

answered Jul 16, 2018 at 21:28

Kahn Kah

1,4637 gold badges27 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Stefano Buora Over a year ago

even the initialization of restart and the test for the while loop need to be fixed.

EvOlaNdLuPiZ Over a year ago

suggestion, initialize your variables (int's). by doing so you're following the proper path to generating a deterministic program, one that is easier to debug, much more in more advanced cases you're taking simple measures to prevent memory leaks. in doing so, your program performs better and removes ambiguity.

Collectives™ on Stack Overflow

While loop and if/else statement not working correctly

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related