ReactJS fetch causes infinite loop

Question

I have two apps one of them is NodeJS listening 5000's port and the other is ReactJS listening 3000's port.

I can return JSON from NodeJS like this (http://localhost:5000/api/28/10/2018):

{
  "date": "28.10.2018",
  "across": [
    {"no": "1", "text": "Warning about an incoming projectile"},
    {"no": "5", "text": "Rapper/producer behind Beats headphones"},
    {"no": "6", "text": "Noble gas below xenon on the periodic table"},
    {"no": "7", "text": "Setting for much of \"Finding Nemo\""},
    {"no": "8", "text": "Looney Tunes character who says \"Th-th-th-that's all, folks!\""}
  ],
  "down": [
    {"no": "1", "text": "Harry's enemy at Hogwarts"},
    {"no": "2", "text": "Milk dispenser"},
    {"no": "3", "text": "Sound from a frog"},
    {"no": "4", "text": "Country music star Chesney"},
    {"no": "5", "text": "The shape of water?"}
  ],
  "cells": ["-1","1","2","3","4","5","0","0","0","0","6","0","0","0","0","7","0","0","0","0","8","0","0","0","0"]
}

I want to display this data with ReactJS but when I try fetch method it creates endless loop. How to solve this?

My ReactJS code:

drawTable = (props) => {
  /* Some if-elseif that is not related to the question */
  else {
    // here props.type get an array that hold input from terminal
    let day, month, year;
    day = props.type[1];
    month = props.type[2];
    year = props.type[3];

    if (day === undefined || month === undefined || year === undefined) {
      console.log("Please use get-old command properly!");
      console.log("Usage:\nget-old day month year");
      console.log("Example:\nget-old 28 10 2018");
      return idle;
    }
    // If arguments defined go fetch
    let url = `http://localhost:${REACT_PORT}/old/${day}/${month}/${year}`;
    fetch(url)
    .then((response) => response.json())
    .then((data) => {
      this.setState({data: data});
    })
    .catch((error) => {
      console.error(error);
    });
    console.log(this.state.data);
  }
}

This log many JSON object.

@Jayce444 I call the function in render,return method like this: {this.drawTable(this.props)} — Mehmet Ali
– Mehmet Ali, Commented Nov 3, 2018 at 22:29
You call drawTable in the render method, which causes a fetch request. When this completes, you put the response in state with setState which causes your component to re-render, and it continues like this indefinitely. You could instead get the data in componentDidMount and componentDidUpdate. — Tholle
– Tholle, Commented Nov 3, 2018 at 22:35
@Tholle thank you very much for the answer! I totally get it but I'm still not able to implement it in my code. How can I implement that in the code? — Mehmet Ali
– Mehmet Ali, Commented Nov 3, 2018 at 22:40

Tholle · Accepted Answer · 2018-11-03 23:44:33Z

You call drawTable in the render method, which causes a fetch request. When this completes, you put the response in state with setState which causes your component to re-render, and it continues like this indefinitely.

You could instead get the data in componentDidMount and componentDidUpdate and just use the data in the render method.

Example

class MyComponent extends React.Component {
  // ...

  componentDidMount() {
    this.fetchData();
  }

  componentDidUpdate(prevProps) {
    const [, prevDay, prevMonth, prevYear] = prevProps.type;
    const [, day, month, year] = this.props.type;

    if (prevDay !== day || prevMonth !== month || prevYear !== year) {
      this.fetchData();
    }
  }

  fetchData = () => {
    const [, day, month, year] = this.props.type;
    const url = `http://localhost:${REACT_PORT}/old/${day}/${month}/${year}`;

    fetch(url)
      .then(response => response.json())
      .then(data => {
        this.setState({ data });
      })
      .catch(error => {
        console.error(error);
      });
  };

  render() {
    // ...
  }
}

Collectives™ on Stack Overflow

ReactJS fetch causes infinite loop

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related