How to update array elements in MongoDB instead of creating new one

Question

I have problem with my code. I want to update document, which looks like this:

    {
"_id": {
    "$oid": "5bf2ad5a0d46b81798232cf9"
},
"manufacturer": "VW",
"model": "Golf ",
"VIN": "WVWZZZ1J212566691",
"doors": 3,
"class": "compact",
"reservations": [
    {
        "_id": {
            "$oid": "5bf2ad5a0d46b81798232cfa"
        },
        "pick_up_date": {
            "$date": "2014-10-13T09:13:00.000Z"
        },
        "drop_off_date": {
            "$date": "2014-10-14T09:13:00.000Z"
        },
        "user_id": {
            "$oid": "5bec00bdfb6fc005dcd5423b"
        }
    }
],
"createdAt": {
    "$date": "2018-11-19T12:32:26.665Z"
},
"updatedAt": {
    "$date": "2018-11-19T12:32:26.665Z"
},
"__v": 0
  }

I want to add new reservation to array Reservations. My function:

const createReservationForCarId = ({ body , params }, res, next) =>
    Carmodel.findById(params.id)
        .then(notFound(res))
        .then((carmodel) => carmodel ? Object.assign(carmodel, body).save() : null)
        .then((carmodel) => carmodel ? carmodel.view(true) : null)
        .then(success(res))
        .catch(next)

But when I'm trying to update through:

router.put('/:id/reservation',
    createReservationForCarId)

Body:

{

    "reservations":[

    {

        "pick_up_date" : "October 13, 2017 11:13:00",  
        "drop_off_date": "October 14, 2017 11:13:00",
        "user_id":"5bec00bdfb6fc005dcd5423b"

    }
    ]
}

Mongo instead of update my old document is creating new one with only one reservation gave in above body.

What should I do to only update existing document, not creating new one?

docs.mongodb.com/manual/reference/method/db.collection.update — Ferus7
– Ferus7, Commented Nov 19, 2018 at 14:03

Sunny Parekh · Accepted Answer · 2018-11-20 06:46:23Z

2

I suggest you use $push operator of Mongoose which will append your object to the existing array and it will not create a new one.

Check out this link:- https://github.com/Automattic/mongoose/issues/4338

edited Nov 20, 2018 at 6:46

answered Nov 20, 2018 at 6:38

Sunny Parekh

1,0019 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Susmita Bhattacharjee · Accepted Answer · 2018-11-19 14:43:39Z

0

You can try the findAndModify instead of findById in your code. Check out the syntax here

answered Nov 19, 2018 at 14:43

Susmita Bhattacharjee

1561 gold badge2 silver badges6 bronze badges

2 Comments

Matthew Over a year ago

I have modified my method and changed findById(), to findByIdAndUpdate(), but now it modifies existing document, in detail existing array object in Reservations. I want to add new object to array, not modify existing. mongoosejs.com/docs/api.html#model_Model.findByIdAndUpdate How to fix this? @Susmita Bhattacharjee

Susmita Bhattacharjee Over a year ago

You can use $push property to append new elements to your reservation array. Take a look at the accepted answer of this. In this example, try replacing { "$push": { "childrens": employee._id }} with something like { "$push": { "reservations": {"newelement1": "newvalue1", "newelement2":"newvalue2"} }}

derekjgrove · Accepted Answer · 2018-11-19 22:02:46Z

0

I haven't used mongoose but they have documentation for array manipulation.

See here: https://mongoosejs.com/docs/api.html#mongoosearray_MongooseArray-push

Also here is the related mongo doc for array manipulation: https://docs.mongodb.com/manual/reference/operator/update/push/

answered Nov 19, 2018 at 22:02

derekjgrove

115 bronze badges

Collectives™ on Stack Overflow

How to update array elements in MongoDB instead of creating new one

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related