Refactoring of the hard code in javascript

Question

I have some API to launch my project, here is the part of code, I want to ask about

getList(oauth2Client).then(items => {
            for (const item of items) {
              if (item.selected && (item.id === '[email protected]' || item.id === '[email protected]')) {
                promiseArray.push(getEvents(oauth2Client, item.id, item.backgroundColor));
              }
            }

How can i do the if statement without hard code, I mean change those two specific emails to some common use case.

Is items an array, and is promiseArray empty at the beginning? (if so, the code can be made prettier) — CertainPerformance
– CertainPerformance, Commented Dec 14, 2018 at 7:29

CertainPerformance · Accepted Answer · 2018-12-14 07:31:46Z

2

Use an array or Set instead:

getList(oauth2Client).then(items => {
  const emails = new Set(['[email protected]', '[email protected]']);
  for (const item of items) {
    if (item.selected && emails.has(item.id)) {
      promiseArray.push(getEvents(oauth2Client, item.id, item.backgroundColor));
    }
  }
});

I'd prefer a Set because it has lower complexity, but with an array, use .includes:

getList(oauth2Client).then(items => {
  const emails = ['[email protected]', '[email protected]'];
  for (const item of items) {
    if (item.selected && emails.includes(item.id)) {
      promiseArray.push(getEvents(oauth2Client, item.id, item.backgroundColor));
    }
  }
});

Or, if you want any email address to pass, use a regular expression, something like:

getList(oauth2Client).then(items => {
  const emailRe = /^\w+@[a-z0-9]\.[a-z]+$/i;
  for (const item of items) {
    if (item.selected && emailRe.test(item.id)) {
      promiseArray.push(getEvents(oauth2Client, item.id, item.backgroundColor));
    }
  }
});

(if you want to be even more rigorous, see the regex here)

edited Dec 14, 2018 at 7:31

answered Dec 14, 2018 at 7:27

CertainPerformance

373k55 gold badges354 silver badges359 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Серега Бубело Over a year ago

Thanks, but I don't need only those '[email protected]', '[email protected]' emails to be correct, i want any email address to be ok to pass.

Серега Бубело Over a year ago

OK, appreciate your help.

Collectives™ on Stack Overflow

Refactoring of the hard code in javascript

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related