laravel 5.5 eloquent query builder build wrong query when storing url with query string

Question

i have an eloquent model with url and data, and other standard laravel fields.

then i do:

        $cache = new \App\Cache();
        $cache->url = $this->url;
        $cache->data = json_encode($data);
        $cache->save();

when url have no query string, it works perfectly, but when url have query string, laravel generate wrong query such as:

original data:

$this->url = 'https://some-url.com?param1=val1&param2=val2';
$data = ['some' => 'long', 'json' => 'data'];

turns to:

insert into `cache` (`url`, `data`, `updated_at`, `created_at`) 
values (
    https://some-url.com{"some":"long","json":"data"}param1=val1&param2=val2, 
    2019-01-07 07:38:15, 
    ?, 
    ?
)

as you can see, the encoded json is put on the wrong place (on the ? of the query string)

what did i do wrong? or this is a bug?

note: i'm using mysql

update: removed the error string as it distracting to the main issue

url is string (191), data is longtext, the json should go to data, not to url — am05mhz
– am05mhz, Commented Jan 7, 2019 at 8:20
I guess you have to increase size of url column. Try doing that. — Prashant Deshmukh.....
– Prashant Deshmukh....., Commented Jan 7, 2019 at 8:22
too long is not the problem, problem is the placement of the json — am05mhz
– am05mhz, Commented Jan 7, 2019 at 8:22
This has nothing to do with length of the fields. It's because Laravel uses ? as placeholders for data in queries. — Jerodev
– Jerodev, Commented Jan 7, 2019 at 8:29

Manoj Patel · Accepted Answer · 2019-01-07 08:37:49Z

1

I believe you need to store the URL like that in DB

$url_string = $this->url;
$cache->url = '{$url_string}';

It will be work for URLs

answered Jan 7, 2019 at 8:37

Manoj Patel

3293 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

am05mhz Over a year ago

sorry, was a mistake, this do save the data, but the url is saved as just '{$url}'

Arman sheikh · Accepted Answer · 2019-01-07 08:35:28Z

0

I think you should type cast the url as string and then save it or use the standard create() method this should work. I have used in one of my projects with no issue.

answered Jan 7, 2019 at 8:35

Arman sheikh

1962 silver badges7 bronze badges

Comments

behnam · Accepted Answer · 2019-01-07 08:39:30Z

0

You can use urlencode() function. Try save your url with encoding.

$cache->url = urlencode($this->url);

and later you can get it with urldecode() function.

answered Jan 7, 2019 at 8:39

behnam

2251 silver badge8 bronze badges

1 Comment

am05mhz Over a year ago

might do this work around if there is no other options

am05mhz · Accepted Answer · 2019-03-19 01:24:40Z

0

turns out its a bug on the sql logger that produce wrong sql snipet. the main error is just that the field length does not fit the data length as @Sohel0415 suggested.

so the logger is misleading me to think that the generated query is wrong.

answered Mar 19, 2019 at 1:24

am05mhz

2,9052 gold badges26 silver badges37 bronze badges

Collectives™ on Stack Overflow

laravel 5.5 eloquent query builder build wrong query when storing url with query string

4 Answers 4

1 Comment

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related