insert data in database using pdo and oops

Question

i want, when user press submit button the enterted data save in database...
Showing no eror but still no data is inserted in database.

please help

<?php
class database
{
    private $connect;
    function __construct()
    {
        $this->connect=new PDO('mysql:host=localhost;dbname=bfgi','root','');
    }
    function insert($institution,$position,$positionname,$department,$natureofjob,$cametoknow)
    {
        $this->connect->query("INSERT INTO contact_form(institution,position,positionname,department,natureofjob,cametoknow) VALUES('$institution','$position','$positionname','$department','$natureofjob','$cametoknow')");
        return true;
    }
}
$obj=new database();

if(!empty($_POST['sbmt']))
{
    $institution=$_POST['institution'];
    $position=$_POST['position'];
    $positionname=$_POST['positionname'];
    $department=$_POST['department'];
    $natureofjob=$_POST['natureofjob'];
    $cametoknow=$_POST['cametoknow'];

    if($obj->insert($institution,$position,$positionname,$department,$natureofjob,$cametoknow))
    {
        echo "INSERTED";
    }
}
?>

please tell the error..

You're not doing anything with the database class. You have it defined, but never use it. — aynber
– aynber, Commented Mar 1, 2019 at 17:20
What error does it show? Please edit your post (not in comments) with the current code, and the exact error you're getting. — aynber
– aynber, Commented Mar 1, 2019 at 17:44
1) MySQL returns errors differently than PHP. You need to check for PDO errors instead of blindly assuming that it works. 2) You are wide open for SQL injection. Since you're using PDO, take advantage of prepared statements and bindparam or bindvalue. This will take care of any pesky quoting issues that may occur. — aynber
– aynber, Commented Mar 1, 2019 at 18:28

Adrien · Accepted Answer · 2019-03-01 17:29:53Z

1

This code only do declarations and variable affectations.

In the first part you define a class, named database, with 2 methods :

A constructor, a special method used to initialize your class
The insert() method

The second part just puts some $_POST variables in another variables.

To insert a column with this code, you need to construct a database instance ($db = new database();) and to call the insert method on it ($db->insert(...)), with the $_POST parameters you have.

Beside from that, you should not mix declaration (e.g. class or function declaration) and code with sides effects (code that will be executed).

You should also not put raw variables coming from the user in your code, because of SQL Injection risks.

You can read PHP The right way, where there is a list of standards and good habits for PHP.

answered Mar 1, 2019 at 17:29

Adrien

4974 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

karan loona Over a year ago

$obj=new database(); if($obj->insert($institution,$position,$positionname,$department,$natureofjob,$cametoknow)

Adrien Over a year ago

Just note that $obj->insert() will return null (because there is no return statement), so your condition will always be false

karan loona Over a year ago

so what should i return..?

Adrien Over a year ago

@karanloona You should return the result of $this->connect->query() which is false on case of error : php.net/manual/en/pdo.query.php#refsect1-pdo.query-returnvalues . In case of success however it returns a PDOStatement object (which will evaluate to true in a condition), if you want to just return a boolean you can use a ternary condition (1) or a double negation (2). 1. return $this->connect->query(...) ? true : false; 2. return !!$this->connect->query(...)

Collectives™ on Stack Overflow

insert data in database using pdo and oops

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related