Split csv file using lambda expression

Question

I'm trying to refactor this method to use a lambda expression:

 public List<String> getHttpsLinksFromCsvList() {
        List<String> data = getDataFromCsv();
        List<String> httpLinks = new ArrayList<>();

        data.forEach(System.out::println);
        for (String value : data) {
            String[] arrayString = value.split(COMMA_DELIMITER);

            for (String item : arrayString) {
                if (item.endsWith(".git")) {
                    httpLinks.add(item);
                }
            }
        }

        //httpLinks.forEach(System.out::println);

        return httpLinks;
    }

Ideally I want to get remove the two nested for loops and optimise it a bit. Is it possible?

Youcef LAIDANI · Accepted Answer · 2019-03-29 18:25:56Z

4

Try this:

List<String> httpLinks = getDataFromCsv().stream()
        .map(value -> value.split(COMMA_DELIMITER))
        .flatMap(Arrays::stream)
        .filter(item -> item.endsWith(".git"))
        .collect(Collectors.toList());

edited Mar 29, 2019 at 18:25

Youcef LAIDANI

60.3k21 gold badges111 silver badges178 bronze badges

answered Mar 29, 2019 at 12:49

star67

1,92212 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Split csv file using lambda expression

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related