How to delete the certain data from array

Question

I am new in ionic 4. I am doing shopping cart function. I want to delete the selected item. But it delete like pop function not delete the certain item. I have follow this tutorial : https://devdactic.com/dynamic-ionic-4-slides/

In service ts I am using this function then Cart.page.ts

onDeleteItem(i) {
const index = this.selectedItems.indexOf(i);
if (index > -1) {
this.cartServ.deleteFromCart(i);
this.selectedItems.splice(index, 1);
console.log(this.selectedItems);
}
this.total = this.selectedItems.reduce((a, b) => a + (b.count * b.price), 0);
}

Cart.service

    addToCart(product) {
        this.cartService.addProduct(product);
      }


    deleteFromCart(i) {
    const index = this.cart.indexOf(i);
    if (index > -1) {
      this.cart.splice(index, 1);
    }
}

Anyone can help me?

Is there is reason why you are using 2 duplicate lists. There should be a master list in the Cart service that the Cart.page.ts retrieves with a getter(). You shouldn't be maintaining 2 identical lists. — DevEng
– DevEng, Commented Jul 12, 2019 at 14:45

Sudarshana Dayananda · Accepted Answer · 2019-07-12 16:06:05Z

2

Don't pass the index to deleteFromCart function.

The reason is index of the deleting item in selectedItems array may not be the same index in cart items Array.

Pass the i which is the item, to deleteFromCart function and find the index and use splice.

onDeleteItem(i) {
    ...
    this.cartServ.deleteFromCart(i);
    ...
}

deleteFromCart(i) {
   const items = this.cart.filter(item => item.id === i.id);
   const index = this.cart.indexOf(items[0])
   if (index > -1) {
        this.cart.splice(index, 1);
   }
}

edited Jul 12, 2019 at 16:06

answered Jul 11, 2019 at 15:24

Sudarshana Dayananda

5,2652 gold badges27 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

dipgirl Over a year ago

Thank you for your reply, I already update my coding but after I change it did not change anything.

Sudarshana Dayananda Over a year ago

check whether value of index in deleteFromCart is not equal to -1

Sudarshana Dayananda Over a year ago

not length. I need to know value of index variable .

deleteFromCart(i) {     const index = this.cart.indexOf(i);     console.log(index)     if (index > -1) {         this.cart.splice(index, 1);     } }

Sudarshana Dayananda Over a year ago

ok that is the reason can you tell me what are attributes of the elements in selectedItems array

dipgirl Over a year ago

is item id, I totally follow this website devdactic.com/dynamic-ionic-4-slides

Collectives™ on Stack Overflow

How to delete the certain data from array

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related