Bug in javascript function

Question

I've got a bug when I'm using a javascript function : my function displays the content of a div element but when I uncomment some code it doesn't work anymore. Someone has any idea why ?

    function traverse(){
        var root=document.getElementById('tree0').childNodes;
        for(var i=0;i<root.length;i++) {
                var lis = root[i];
                var number =0;
                for (var member in lis) {
                    output.innerHTML+=lis[member];
                    /*var assertion = lis[member];
                    var result = assertion.indexOf("Bookmarks menu");
                    if(result != -1) {
                       output.innerHTML+='Test';
                    }*/

                 }
         }
     }

thanks,

Bruno

Thanks everyone for answering but I mispelled only when I copied the source code so the error is not here. — Bruno
– Bruno, Commented Apr 19, 2011 at 12:38

mplungjan · Accepted Answer · 2011-04-19 13:12:53Z

4

You may get more that you expect when you do for ... in ...

Is THIS what you want? http://jsfiddle.net/bM9Bn/

<div id="tree0">
  <div id="bla">
    bla
  </div>
  <div id="Bookmarks menu">
    Bookmarks Menu
  </div>
</div>
<hr />
<div id="output"></div>
<script>
var output = document.getElementById("output")
function traverse(){
  var root=document.getElementById('tree0').childNodes;
  for(var i=0;i<root.length;i++) {
    var lis = root[i];
    var number =0;
    for (var member in lis) {
//      output.innerHTML+="["+member+":"+lis[member]+"]";
      if (member == "id" || member == "textContent") {
        output.innerHTML+="["+member+":"+lis[member]+"]";
        var assertion = lis[member];
        // the typeof test not needed if we only process textContent and ID
        if (typeof assertion == "string") { 
          var result = assertion.indexOf("Bookmarks menu");
          if(result != -1) {
            output.innerHTML+='<span style="color:red">Test</span>';
          }
        }
      }
    }
  }
}
traverse()
</script>

edited Apr 19, 2011 at 13:12

answered Apr 19, 2011 at 12:56

mplungjan

180k29 gold badges183 silver badges246 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

mplungjan Over a year ago

@Bruno: What are you looking for. can we please see what the tree looks like. What in a node list can be the string "Bookmars menu" - I would expect asserion.innerHMTL or assertion.textContent or something

RobG Over a year ago

+1 from me. Dunno what the OP wants, but expecting all enumerable properties of a DOM element to be strings is not sensible. Searching through every property looking for a specific string doesn't make sense, surely the OP knows which property is relevant?

mplungjan Over a year ago

@RobG -yes, a document.getElementsByTagName or similar

Jeff Fuller · Accepted Answer · 2011-04-19 12:33:03Z

0

Just looking quickly- var and if statement should both us resultat?

var resultat = assertion.indexOf("Bookmarks menu"); if(result*at* != -1) {

answered Apr 19, 2011 at 12:33

Jeff Fuller

1

Comments

mylesmg · Accepted Answer · 2011-04-19 12:33:37Z

0

You are checking the 'result' variable, but setting the 'resultat' variable. Try using resultAt in the conditional, and I think it will work for you.

answered Apr 19, 2011 at 12:33

mylesmg

5323 silver badges8 bronze badges

Collectives™ on Stack Overflow

Bug in javascript function

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related