How can I add additional single quotes to string in javascript and php? [duplicate]

Question

I'm trying to build a string inside <script></script> which has a variable.

var buildurl = response.show.url;
var connectHtml = '<button class="form_button" id="connectButton" onclick="window.location='+buildurl+'">Connect</button>'
$('#someElement').html(connectHtml);

When I inspect the element, I see the url built but without the single quotes (''). So when I click on the button, it does not navigate to the url. How can I add the '' to get

onclick="window.location='https://something.com/admin/one/two/123/456'" ?

<button class="form_button" id="connectButton" onclick="window.location=https://something.com/admin/one/two/123/456">Connect</button>

Why not just make a function that redirects and then call that onclick? — Funk Doc
– Funk Doc, Commented Sep 12, 2019 at 17:07
@FunkDoc Even if I were to move the "window.location" inside a function, I would still face the issue of missing single quotes. I am not able to add the quotes to the string using a concatenation operator. — user3344978
– user3344978, Commented Sep 12, 2019 at 17:11
Trying to find a good duplicate (I imagine there is one), but in the meantime, onclick="window.location=\''+buildurl+'\'" — Patrick Q
– Patrick Q, Commented Sep 12, 2019 at 17:12
@PatrickQ Here's another way I found - stackoverflow.com/questions/10787393/… . thanks! — user3344978
– user3344978, Commented Sep 12, 2019 at 17:15
Which ever quotes you're using as delimiter for your string have to be escaped when you want to use them in that same string. — Andreas
– Andreas, Commented Sep 12, 2019 at 17:15

Lajos Arpad · Accepted Answer · 2019-09-12 17:26:58Z

1

You can use template literals and not worry about apostrophes and quotes:

`<button class="form_button" id="connectButton" onclick="window.location='${buildurl}'">Connect</button>`

edited Sep 12, 2019 at 17:26

answered Sep 12, 2019 at 17:18

Lajos Arpad

80.4k42 gold badges123 silver badges234 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Lajos Arpad Over a year ago

@PatrickQ good point, thank you. It's fixed now.

Collectives™ on Stack Overflow

How can I add additional single quotes to string in javascript and php? [duplicate]

1 Answer 1

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Linked

Related