Node.js fetch returns empty data

Question

I'm trying to get some data from an API using fetch, and the console log shows [], however, when I do the same request using Postman, it successfully returns a JSON. What am I doing wrong?

let fetch = require("node-fetch");

const url_deals = 'http://www.cheapshark.com/api/1.0/deals';

function getDealInfo(dealID){
    let new_url = new URL(url_deals + "?id=" + dealID);

    fetch(new_url, {method : 'GET'})
        .then(data =>{
            data.json().then(out => {
                console.log(out);
            })
        })
}

getDealInfo("X8sebHhbc1Ga0dTkgg59WgyM506af9oNZZJLU9uSrX8%253D");

I thing you are not using the same identifier, when I'm trying this url cheapshark.com/api/1.0/… the response its an empty array just like you. — anthony
– anthony, Commented Oct 23, 2019 at 18:20
I got empty result from the link so it seems nothing wrong. are you sure about id? X8sebHhbc1Ga0dTkgg59WgyM506af9oNZZJLU9uSrX8 seems to work — duc mai
– duc mai, Commented Oct 23, 2019 at 18:21

jfriend00 · Accepted Answer · 2019-10-23 18:32:13Z

1

Your id is apparently encoded multiple times. If I decode it twice, I get this:

getDealInfo("X8sebHhbc1Ga0dTkgg59WgyM506af9oNZZJLU9uSrX8=");

And, that actually fetches this data.

{ gameInfo:
   { storeID: '1',
     gameID: '93503',
     name: 'BioShock Infinite',
     steamAppID: '8870',
     salePrice: '29.99',
     retailPrice: '29.99',
     steamRatingText: 'Overwhelmingly Positive',
     steamRatingPercent: '95',
     steamRatingCount: '61901',
     metacriticScore: '94',
     metacriticLink: '/game/pc/bioshock-infinite',
     releaseDate: 1364169600,
     publisher: 'N/A',
     steamworks: '1',
     thumb:
      'https://steamcdn-a.akamaihd.net/steam/apps/8870/capsule_sm_120.jpg?t=1568739647' },
  cheaperStores:
   [ { dealID: 'fq0cNHiR3Z4TpZyV7WH865C1%2BCBlmufYUc%2Bu2HqyUHE%3D',
       storeID: '27',
       salePrice: '26.99',
       retailPrice: '29.99' } ],
  cheapestPrice: { price: '5.27', date: 1543553226 } }

So it, appears that the id value you're passing is incorrect. You can see that the node-fetch() code is working fine by just using it with the base URL: http://www.cheapshark.com/api/1.0/deals and that will return you JSON, confirming that the node-fetch() code works just fine and the issue is with your id value.

answered Oct 23, 2019 at 18:32

jfriend00

711k104 gold badges1.1k silver badges1k bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Bruno Signorelli Domingues Over a year ago

Just found it decoding it online as well. It seems all deal IDs are encoded, so I need to decode them first. Thanks for the help!

jfriend00 Over a year ago

@BrunoSignorelliDomingues - I googled URL decoder and went here: meyerweb.com/eric/tools/dencoder. You can also do it programmatically if required using decodeURIComponent().

Bruno Signorelli Domingues Over a year ago

Had to implement a loop that keeps on decoding the URL until it is no longer able to decode so I could detect those multiple encodings. Thanks!

Codebling · Accepted Answer · 2019-10-23 18:23:18Z

0

The problem is with your ID. You've escaped it twice.

getDealInfo("X8sebHhbc1Ga0dTkgg59WgyM506af9oNZZJLU9uSrX8%253D");

Id in your code is X8sebHhbc1Ga0dTkgg59WgyM506af9oNZZJLU9uSrX8%253D but in the screenshot it is X8sebHhbc1Ga0dTkgg59WgyM506af9oNZZJLU9uSrX8%3D. Look at the 3rd to last digit.

answered Oct 23, 2019 at 18:23

Codebling

11.5k3 gold badges45 silver badges71 bronze badges

Comments

Dave Newton · Accepted Answer · 2019-10-23 18:24:08Z

0

Using that ID I also get nothing.

Note that if you make the request with no id the IDs do not match your format, e.g.,

"dealID":"tnXImZO%2FYSnkve2w7O5fHy77qn0e8uvWFbkiT%2Fjb7r0%3D"

It looks like you have an extra URI encoding going on somewhere.

answered Oct 23, 2019 at 18:24

Dave Newton

161k27 gold badges263 silver badges310 bronze badges

Collectives™ on Stack Overflow

Node.js fetch returns empty data

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related