How to repeat a dynamic string in PHP

Question

I have a dynamic created by PHP which produces different squares with unique sizes and colors. Now, I want to output 100 of these squares to appear on the screen.

I have tried to put my code in a for loop but it does not work:

<?php 
$random_number = rand(10,100);
$color_array=array("yellow"=>"0","red"=>"1","green"=>"2","blue"=>"3","black"=>"4","brown"=>"5", "gray"=>"6");
$random_color = array_rand($color_array,1);
$x= '<div style="width:' . $random_number . 'px;height:' . $random_number . 'px;background-color:' . $random_color . '">';
for ($i = 0; $i <= 100; $i++) {
    echo $x;
}
?>

There are no error messages, but only one square appears instead of 100.

You're computing $x only once, before your loop. You'll want the random number generation to occur at every iteration. — Jeto
– Jeto, Commented Oct 28, 2019 at 14:15

Areg · Accepted Answer · 2019-10-28 14:38:02Z

2

Your variables $random_number, $random_color and $x must be redeclared inside your loop. The reason why you were seeing only one div its because you forgot to close it. It was still generating them but inside one another.

<?php

$color_array=array("yellow"=>"0","red"=>"1","green"=>"2","blue"=>"3","black"=>"4","brown"=>"5", "gray"=>"6");

for ($i = 0; $i <= 100; $i++) {
  $random_number = rand(10,100);  
  $random_color = array_rand($color_array,1);
  $x= '<div style="width:' . $random_number . 'px;height:' . $random_number . 'px;background-color:' . $random_color . '"></div>';
  echo $x;
}
?>

Otherwise you will only echo the same thing over and over again.

edited Oct 28, 2019 at 14:38

Areg

1,5381 gold badge23 silver badges46 bronze badges

answered Oct 28, 2019 at 14:16

Lucas Meine

1,6175 gold badges25 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Kevin Greene Over a year ago

You need to close that div.

Angel Deykov Over a year ago

downvoted since your code overrides the $color_array with each iteration, absolutely no reason to do it !

Lucas Meine Over a year ago

Thanks for the suggestion, I didn't notice that :)

Angel Deykov · Accepted Answer · 2019-10-28 14:25:01Z

-1

<?php
        $color_array=array("yellow"=>"0","red"=>"1","green"=>"2","blue"=>"3","black"=>"4","brown"=>"5", "gray"=>"6");

        for ($i = 0; $i <= 100; $i++) {
          echo '<div style="width:' . rand(10,100) . 'px;height:' . rand(10,100) . 'px;background-color:' . array_rand($color_array,1) . '"></div></br>';
        }
?>

answered Oct 28, 2019 at 14:25

Angel Deykov

1,2371 gold badge11 silver badges16 bronze badges

1 Comment

Lucas Meine Over a year ago

Downvoted because it makes no attempt to explain the code you just wrote. Fix that and I will gladly remove it :)

Collectives™ on Stack Overflow

How to repeat a dynamic string in PHP

2 Answers 2

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related