Improve code with checking element in array is digit

Question

I want to check that each element in String is digit. Firstly, I split the String to an Array by a regexp [, ]+ expression and then I try to check each element by forall and isDigit.

object Test extends App {
  val st = "1, 434, 634, 8"

  st.split("[ ,]+") match {
    case arr if !arr.forall(_.forall(_.isDigit)) => println("not an array")
    case arr if arr.isEmpty                      => println("bad delimiter")
    case _                                       => println("success")
  }
}

How can I improve this code and !arr.forall(_.forall(_.isDigit))?

what answer should be if you pass string 1 2 3, 123? And what do you mean by improve this code? — oybek
– oybek, Commented Nov 14, 2019 at 7:18

Wiktor Stribiżew · Accepted Answer · 2019-11-14 08:04:36Z

1

Use matches that requires the string to fully match the pattern:

st.matches("""\d+(?:\s*,\s*\d+)*""")

See the Scala demo and the regex demo.

Details

In a triple quoted string literal, there is no need to double escape backslashes that are part of regex escapes
Anchors - ^ and $ - are implicit when the pattern is used with .matches
The regex means 1+ digits followed with 0 or more repetitions of a comma enclosed with 0 or more whitespaces and then 1+ digits.

answered Nov 14, 2019 at 8:04

Wiktor Stribiżew

631k41 gold badges502 silver badges632 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

jwvh Over a year ago

Returns false for strings like " 1,2,4" and "1,2,4 ". Not sure if that's desired results or not.

Wiktor Stribiżew Over a year ago

@jwvh It is expected, see the sample input in the question that has no leading/trailing whitespace. Anyway, it can easily be added with \s* at the start and end of the pattern

jwvh Over a year ago

Just curious: Why make it non-capture? What advantage does the ?: add?

Wiktor Stribiżew Over a year ago

@jwvh See Are non-capturing groups redundant?. In short: the best practice is to only use capturing groups only when you need to access part of the regex match after it occurred.

jwvh · Accepted Answer · 2019-11-14 06:07:27Z

1

I think it can be simplified while also making it a bit more robust.

val st = "1,434 , 634   , 8"  //a little messier but still valid

st.split(",").forall(" *\\d+ *".r.matches)  //res0: Boolean = true

I'm assuming strings like "1,,,434 , 634 2 , " should fail.

The regex can be put in a variable so that it is compiled only once.

val digits = " *\\d+ *".r
st.split(",").forall(digits.matches)

edited Nov 14, 2019 at 6:07

answered Nov 14, 2019 at 5:58

jwvh

51.3k7 gold badges42 silver badges70 bronze badges

1 Comment

sumitya Over a year ago

nice approach @jwvh

Collectives™ on Stack Overflow

Improve code with checking element in array is digit

2 Answers 2

4 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related