Problem with Read-Host variable in script (Active Directory filter)

Question

I have created a script in PowerShell (v. 5.1.17763.592) and it doesn't work properly.

$NUMBER = Read-Host 'Enter the number of Organizational Unit (without parentheses)'
$TMPFILENAME = Get-ADOrganizationalUnit -filter 'Name -like "*($NUMBER)*"' | select -ExpandProperty Name

$FILENAME = $TMPFILENAME | Out-String 
$FILENAME = $FILENAME + ".csv"
$FILENAME = $FILENAME -replace '\s',''
$FILENAME = $FILENAME -replace '&',''

$OUNAME = Get-ADOrganizationalUnit -Filter 'Name -like "*($NUMBER)*"' |
          select -ExpandProperty DistinguishedName

New-Item -Path "c:\Raports" -ItemType Directory -ErrorAction SilentlyContinue

Get-ADUser -Filter * -SearchBase $OUNAME | Export-Csv "C:\Raports\$FILENAME"

After run this I'm receiving an error:

Get-ADUser : Cannot validate argument on parameter 'SearchBase'. The argument is
null. Provide a valid value for the argument, and then try running the command
again.
At line:13 char:34
+ Get-ADUser -Filter * -SearchBase $OUNAME | Export-Csv

When I put a $OUNAME content in the Get-ADUser I got error:

Get-ADUser : Cannot bind parameter because parameter 'Filter' is specified more
than once. To provide multiple values to parameters that can accept multiple
values, use the array syntax. For example, "-parameter value1,value2,value3"

If I put a number directly into script (instead of using variable $NUMBER) it is working perfectly, but I want to allow user to enter this number by her/himself.

Edit (after few hours :) )

I've just realized that problem belong to the variable transmission.

Get-ADOrganizationalUnit -filter 'Name -like "*(202)*"' | select -ExpandProperty DistinguishedName

Get-ADOrganizationalUnit -filter 'Name -like "*($abc)*"' | select -ExpandProperty DistinguishedName

Namely, if our variable $abc would be equal to 202 (no matter if we just define it as:

$abc=202           or
$abc="202"         or 
$abc=Read-Host

)
it wont give any result, but if I put 202 directly to the script, the result is acceptable. Can anyone tell me how to solvthat problem ?

Well, I'll be honest, this is my first 'real' script. I need to find OU with specific name and every OU has unique Number. The reason of this script is to get every information GET-ADUser can give me about members of specific OU — Wojtron
– Wojtron, Commented Nov 19, 2019 at 9:20
Unless your OUs do have parenthesis in the name, get-adou cmdlet is likely to return zero items. That's why you need to print ouname variable and see if it contains sensible data, nonsense or is empty. — vonPryz
– vonPryz, Commented Nov 19, 2019 at 9:42

js2010 · Accepted Answer · 2019-11-19 17:55:46Z

0

This type of filter works for me, without the parentheses, and the double-quotes on the outside. The double-quotes need to be on the outside for the $abc variable to be interpreted. Also, parentheses are meaningless inside double-quotes unless preceded by a dollar sign. $( )

-filter "Name -like '*$abc*'"

edited Nov 19, 2019 at 17:55

answered Nov 19, 2019 at 16:02

js2010

28.3k6 gold badges82 silver badges88 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

iRon Over a year ago

Your answer is correct but probably requires some explanation about quoting rules

Wojtron · Accepted Answer · 2019-11-20 08:47:34Z

0

Alright. I've found the issue. The apostrophe and quotation marks should be reversed.

    **WRONG**
Get-ADOrganizationalUnit -filter 'Name -like "*($abc)*"' | select -ExpandProperty DistinguishedName**strong text**

.

 **CORRECT*
Get-ADOrganizationalUnit -filter "Name -like '*($abc)*'" | select -ExpandProperty DistinguishedName

answered Nov 20, 2019 at 8:47

Wojtron

12 bronze badges

Comments

LeoE · Accepted Answer · 2019-11-19 13:11:26Z

-1

Define the variable type for $NUMBER as [String], It may work.

[String]$NUMBER = Read-Host 'Enter the number of Organizational Unit (without parentheses)'

edited Nov 19, 2019 at 13:11

LeoE

2,0831 gold badge15 silver badges32 bronze badges

answered Nov 19, 2019 at 12:29

Vikram Garimella

11 bronze badge

1 Comment

Wojtron Over a year ago

thank you for effort, but it doesn't work. GET-ADUser still doesn't recognize $OUNAME as proper argument. The most annoying fact is - like i said before - that script works with directly entered number.

Collectives™ on Stack Overflow

Problem with Read-Host variable in script (Active Directory filter)

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related