PHP loop through array and execute statements

Question

I have this code for inserting prepared values into MySQL with PDO, but am looking for a way to tidy it up with a loop, to avoid repetition:

// PDO connect
    $pdo = new PDO($sqldsn, $sqluser, $sqlpass, $sqlopt);

    // Prepare query
    $stm = $pdo->prepare("$query");

    // Cycle through additional values
    foreach(func_get_args() as $arg) {
    $sqlarray[] = $arg;
    }

    // Execute query with values
    $count = count($sqlarray);

    if ($count == "2") { $stm->execute([$sqlarray[1]]); } 
    if ($count == "3") { $stm->execute([$sqlarray[1], $sqlarray[2]]); }
    if ($count == "4") { $stm->execute([$sqlarray[1], $sqlarray[2], $sqlarray[3] ]); }
    if ($count == "5") { $stm->execute([$sqlarray[1], $sqlarray[2], $sqlarray[3], $sqlarray[4] ]); } 
    if ($count == "6") { $stm->execute([$sqlarray[1], $sqlarray[2], $sqlarray[3], $sqlarray[4], $sqlarray[5] ]); }
    if ($count == "7") { $stm->execute([$sqlarray[1], $sqlarray[2], $sqlarray[3], $sqlarray[4], $sqlarray[5], $sqlarray[6] ]); }


    // Fetch all
    $result = $stm->fetchAll();

    // Return result    
    return $result;

I've tried looping like this, but I don't get any results (other than the number of array entries):

    for ($i = 1; $i<=$count; $i++){
        echo $i;
        $stm->execute([$sqlarray[$i]]);
    }

I also tried to construct the sections using eval(), but understand that this isn't a safe idea for security reasons.

I just need it to cycle through as per my code, but without having to specify each number of possible prepared ? values. Can anyone help? Sorry for the newb question, but I'm currently learning PHP.

GrumpyCrouton · Accepted Answer · 2019-12-13 13:49:53Z

3

You don't really need any loops at all.

You should be able to get the results you want with just a few lines of code;

$pdo = new PDO($sqldsn, $sqluser, $sqlpass, $sqlopt);

// Prepare query
$stm = $pdo->prepare($query);

$arr = array_values(func_get_args()); //gets rid of your foreach loop
array_shift($arr); //gets rid of first element of array

$stm->execute($arr);

return $stm->fetchAll();

edited Dec 13, 2019 at 13:49

answered Dec 12, 2019 at 21:53

GrumpyCrouton

8,6367 gold badges37 silver badges81 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jack Warren Over a year ago

Great, that works perfectly, and with succinct code! Many thanks! :)

richyen · Accepted Answer · 2019-12-12 21:41:37Z

0

You can just remove the first element with array_shift:

// PDO connect
    $pdo = new PDO($sqldsn, $sqluser, $sqlpass, $sqlopt);

    // Prepare query
    $stm = $pdo->prepare("$query");

    // Cycle through additional values
    foreach(func_get_args() as $arg) {
    $sqlarray[] = $arg;
    }

    // Execute query with values
    $arr   = $sqlarray;  // Make a copy
    $first = array_shift($arr);  // Remove the first element
    $stm->execute($arr);  // Execute query with resulting array

    // Fetch all
    $result = $stm->fetchAll();

    // Return result    
    return $result;

answered Dec 12, 2019 at 21:41

richyen

10.3k4 gold badges18 silver badges36 bronze badges

3 Comments

Aran Over a year ago

Be careful using array_shift() with large arrays as each time an element is added or removed to the start of an array, the process for re-indexing all the other keys isn't efficient on larger arrays.

Jack Warren Over a year ago

Thanks for your help! That works, but grumpy's answer avoids the loop altogether. :)

richyen Over a year ago

you're welcome! I had simply tried to address the repetition. Didn't realize you wanted to remove the foreach loop as well. But yes, @grumpy's solution is more elegant

Collectives™ on Stack Overflow

PHP loop through array and execute statements

2 Answers 2

1 Comment

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related