How to handle request with parameter of wrong type in .NET Core? [duplicate]

Question

So I have this problem that I have endpoint like

        [HttpGet("get/{id}")]
        public async Task<IActionResult> Get([FromRoute] long? id)
        {
            if (id == null)
                return BadRequest();
            var result = await Mediator.Send(new GetIssueByIdQuery(id));
            return CreateResponse(result);
        }

and if I send request like

..../get/1

everything works fine. But if I give id parameter of different type, eg.:

.../get/asd

the server automagically responds with some generic validation error and 404. Since the request doesn't even hit the endpoint, how can I handle this situation myself and return some more descriptive information to the client?

Does this answer your question? Validating and passing controller-level parameters with ASP.NET MVC attribute routing — oleksa
– oleksa, Commented Jan 18, 2020 at 11:22

Alexander Goldabin · Accepted Answer · 2020-01-18 11:13:15Z

2

You could change type of id parameter to the string and try to parse it by yourself:

public async Task<IActionResult> Get([FromRoute] string id)
{
    if (string.IsNullOrWhiteSpace(id))
        return BadRequest($"{nameof(id)} parameter should not be empty");
    if (!long.TryParse(id, out var longValue))
        return BadRequest($"{nameof(id)} should be convertible to long");

    var result = await Mediator.Send(new GetIssueByIdQuery(longValue));
    return CreateResponse(result);
}

answered Jan 18, 2020 at 11:13

Alexander Goldabin

1,95318 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to handle request with parameter of wrong type in .NET Core? [duplicate]

1 Answer 1

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Linked

Related