Java, socket, thread

Question

Hello dear StackOverflow users. I come here again to answer a question about Java Socket and Thread. My current code:

new Thread(()->{
             System.out.println("Thread.......");
            try {
                while(true){
                     ServerSocket serverSocket = new ServerSocket(serverPort);
                     Socket socket = serverSocket.accept();
                        final InputStreamReader streamReader = new InputStreamReader(socket.getInputStream());
                        BufferedReader br = new BufferedReader(streamReader);
                        String line = null;
                        while ((line = br.readLine()) != null){
                            JsonObject result = new Gson().fromJson(line, JsonObject.class);
                            String token = result.get("serverToken").getAsString();
                            String player = result.get("player").getAsString();
                            String value = result.get("quantity").getAsString();
                            System.out.println(token+"/"+serverToken);
                            if(token.equals(serverToken)){
                                String command = activeCommand;
                                       command = activeCommand.replace("%value%", value);
                                       command = activeCommand.replace("%player%", player);
                                execCommand(command);
                                System.out.println("Acertou a token!");
                            }else{
                                System.out.println("Token incorreta!");
                            }
                        }
                     serverSocket.close();
                     socket.close();
                     Boolean isClosed = socket.isClosed();
                     System.out.print(isClosed);
                  } 
            } catch (IOException e) {
                System.out.println(e);
            }
        }).start();

It works well, up to a point. After a few requests, it simply gives the error: java.net.BindException: Address already in use (Bind failed)

I've been looking for some time, but I haven't found a solution. Thanks in advance.

You're not closing a ton of Closeable objects, you definitely need to. It's possible an exception is being thrown and being swallowed, causing the socket not to be closed. — Jason
– Jason, Commented Feb 1, 2020 at 0:48
Is there anything that fires as soon as a thread is closed, to close the connection together? @Jason — Vitor cândido
– Vitor cândido, Commented Feb 1, 2020 at 0:54
Not a Thread no, but you can use a Callable<T> and on result, ensure the socket is closed. I'll have an answer below. — Jason
– Jason, Commented Feb 1, 2020 at 0:57

Jason · Accepted Answer · 2020-02-01 01:02:01Z

I don't have a definitive answer but what I do have is some possible problems and some improvements.

You're not closing some Closeable resources.
An exception may be thrown and not caught in this thread.

Improvements

4 Closeable objects all put into multiple try-with-resources.
You're now using a ThreadFactory that prints all uncaught exceptions.
You're now printing the IOException, if one occurs.
You're now using a ExecutorService that uses the ThreadFactory.

        ThreadFactory threadFactory = new ThreadFactoryBuilder()
                .setUncaughtExceptionHandler((thread, throwable) -> throwable.printStackTrace())
                .setNameFormat("my-server-thread")
                .build();

        ExecutorService service = Executors.newSingleThreadScheduledExecutor(threadFactory);

        service.submit(() -> {
            while(true) {
                try (ServerSocket serverSocket = new ServerSocket(port)) {
                    try (Socket socket = serverSocket.accept()) {
                        try (InputStreamReader streamReader = new InputStreamReader(socket.getInputStream());
                             BufferedReader br = new BufferedReader(streamReader)) {
                            String line;

                            while ((line = br.readLine()) != null) {
                                // your other code in here
                            }
                        }
                    }
                } catch (IOException ioe) {
                    ioe.printStackTrace();
                }
            }
        });

Collectives™ on Stack Overflow

Java, socket, thread

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related