Update a List's object using Linq

Question

I would like to assign an object in a list using Linq, but I can't find how to do it. I tried this:

Items.Where(i => i.Code == line.Code).Single() = line;

But it seems I simply cannot give the statement an object. I can modify properties of those objects (Like this) :

Items.Where(i => i.Code == line.Code).Single().name = line.name;

But giving it the full item doesn't seem to be accepted. Is there a reason to prevent this / a way to assign my value to the compatible item ? Thank you for your answer.

Yeldar Kurmangaliyev · Accepted Answer · 2020-02-17 10:53:32Z

3

You cannot replace the value in the list using LINQ, because LINQ is a projection of a collection.

You can get your item and then find it in the list using IndexOf:

var item = Items.Single(i => i.Code == line.Code);
int index = Items.IndexOf(item);
Items[index] = new Item(); // replace the value

However, this approach is far from optimal in terms of algorithmic complexity, because it has to read through your list multiple times.
You can try to read more on Dictionary to find, add or replace items by key (in your case, Code) efficiently.

answered Feb 17, 2020 at 10:53

Yeldar Kurmangaliyev

34.3k13 gold badges64 silver badges104 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Prasad Telkikar · Accepted Answer · 2020-02-17 11:00:31Z

3

From MSDN Documentation: Language Integrated Query

By using query syntax, you can perform filtering, ordering, and grouping operations on data sources with a minimum of code.

You can not perform assignment using LINQ, you need to use index to update particular record from the list

To update record you can try FindIndex()

int index = Items.FindIndex(x => x.Code == line.Code); //returns -1 if record not found
Items[index]?.Name = "Stackoverflow";

edited Feb 17, 2020 at 11:00

answered Feb 17, 2020 at 10:54

Prasad Telkikar

16.1k7 gold badges26 silver badges49 bronze badges

Comments

Marc Gravell · Accepted Answer · 2020-02-17 10:56:16Z

1

Single() is a method that returns a value. You can't usually assign to the return from an expression. It is ultimately no different to saying:

Math.Max(32, 42) = 14;

at which point, Max is going to say "um, no; I was telling you the answer - I wasn't expecting you to tell me".

In theory, what you want here is possible, but only in advanced scenarios involving ref-returns. LINQ does not deal with ref-returns.

answered Feb 17, 2020 at 10:56

Marc Gravell

1.1m273 gold badges2.6k silver badges3k bronze badges

Comments

Christos · Accepted Answer · 2020-02-17 10:59:11Z

1

Think about what the Single method returns. It returns a reference to the object that much the predicate you pass in the Where method. Specifically, when there is only one item in the Items that pass the predicate in the Where method, you will get a reference to this object. If there are more than one items, you will get an exception and if there are no items you will get null. Let's think about the happy case, in which you will have only one item. In that case, essentially you try to assign to this reference a new object. This does not make any sense. On the other hand that you try afterwards, makes sense, holding the reference you can mutate its state.

edited Feb 17, 2020 at 10:59

answered Feb 17, 2020 at 10:53

Christos

54.1k9 gold badges82 silver badges114 bronze badges

Comments

Vinod Kumar · Accepted Answer · 2020-02-17 11:01:05Z

0

Will below linq address your requirement?

      items.Where(i => i.Code== line.code)?.ToList()?.ForEach(i => i.name= line.name);

answered Feb 17, 2020 at 11:01

Vinod Kumar

4181 gold badge5 silver badges19 bronze badges

2 Comments

Ryan L Over a year ago

No there are a lot of properties to change in one single object and I thought it would be better to directly give the new object than doing a lot of times the Linq query, Thank you for your answer though

Vinod Kumar Over a year ago

@RyanL then we can use like, items.Where(i => i.Code== line.code)?.ToList()?.ForEach(i => i = line) right?

Collectives™ on Stack Overflow

Update a List's object using Linq

5 Answers 5

Comments

Comments

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related