using jQueryUI with closure compiler

Question

I am having trouble getting a js app that uses jQuery UI to work after minifying using the closure compiler.

What I did:

Go here and load up the jqueryui js file
Asked to extern jQuery.ui
Copied the result to a file and used it as an extern file

The app broke, though. The dialogs do not show correctly anymore. The explosion effect doesn't work correctly, and there are several dialogs created. It is interesting that jQuery UI itself is working somewhat, since the dialogs were created. It is just that the app is misbehaving.

Am I missing something?

What do you mean by "asked to extern jQuery.ui? What did you do? — Dave
– Dave, Commented Aug 2, 2011 at 14:24
@Dave: I assume (s)he used the linked tool to generate an extern file. — Dan Abramov
– Dan Abramov, Commented Feb 11, 2012 at 0:29

Chad Killingsworth · Accepted Answer · 2012-05-04 13:20:35Z

1

The linked externs extractor doesn't appear to be able to extract externs from jQuery style files. This is most likely because jQuery uses the "extend" method to assign objects and that tool doesn't recognize that these properties need to be externed as well.

To address the issue, you would need to unravel the extend calls into direct assignments:

jQuery.extend(jQuery.ui, { prop1: function() {}, prop2: function() {});

Would become

jQuery.ui = jQuery.ui || {};
jQuery.ui.prop1 = function() {};
jQuery.ui.prop2 = function() {};

Also, when dealing with jQuery and using advanced optimizations, the "$" alias should be avoided completely.

This is just one of several reasons why compiling jQuery code with Closure-compiler advanced optimizations is challenging.

answered May 4, 2012 at 13:20

Chad Killingsworth

14.4k2 gold badges37 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

using jQueryUI with closure compiler

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related