Update SQL Query not working ASP.NET Core C# Console App

Question

Working on a project which will update a column in my database with the users instagram ID. When I try run the query it isn't updating the column I've specified in my query.

I'm trying to update a table based off the Instagram ID of a user but nothing is being updated on my dev db. I feel like it has something to do with my SQL query

public static async Task<InstagramUser> ScrapeInstagram(string url)
        {
            using (var client = new HttpClient())
            {
                var response = await client.GetAsync(url);
                if (response.IsSuccessStatusCode)
                {
                    // create html document
                    var htmlBody = await response.Content.ReadAsStringAsync();
                    var htmlDocument = new HtmlDocument();
                    htmlDocument.LoadHtml(htmlBody);

                    // select script tags
                    var scripts = htmlDocument.DocumentNode.SelectNodes("/html/body/script");

                    // preprocess result
                    var uselessString = "window._sharedData = ";
                    var scriptInnerText = scripts[0].InnerText
                        .Substring(uselessString.Length)
                        .Replace(";", "");

                    // serialize objects and fetch the user data
                    dynamic jsonStuff = JObject.Parse(scriptInnerText);
                    dynamic userProfile = jsonStuff["entry_data"]["ProfilePage"][0]["graphql"]["user"];

                    //Update database query 
                    string connectionString = @"Server=myproject-dev-db.cothtpanmcn7.ap-southeast-2.rds.amazonaws.com;Database=Enrolment;User Id=testadmin;Password=test123;MultipleActiveResultSets=true;Trusted_Connection=False;";

                    using (SqlConnection con = new SqlConnection(connectionString))
                    {
                        SqlCommand cmd = new SqlCommand("Update ApplicationUser Set InstagramId = '" + userProfile.id + "'" + "where Instagram =  '" + userProfile.username + "'", con);


                    }
                   
                    // create an InstagramUser
                    var instagramUser = new InstagramUser
                    {
                        FullName = userProfile.full_name,
                        FollowerCount = userProfile.edge_followed_by.count,
                        FollowingCount = userProfile.edge_follow.count,
                        Id = userProfile.id,
                        url = url
                    };
                    return instagramUser;
                } else
                {
                    throw new Exception($"Something wrong happened {response.StatusCode} - {response.ReasonPhrase} - {response.RequestMessage}");
                }
            }
        }

Answered my own question I was missing the following lines: cmd.Connection.Open(); cmd.ExecuteNonQuery(); — rey123
– rey123, Commented Sep 16, 2020 at 3:01
SQL Injection alert - you should not concatenate together your SQL statements - use parametrized queries instead to avoid SQL injection - check out Little Bobby Tables — marc_s
– marc_s, Commented Sep 16, 2020 at 3:50

rey123 · Accepted Answer · 2020-09-16 03:05:45Z

1

Answered my own question:

Was missing the following lines of code:

cmd.Connection.Open();
cmd.ExecuteNonQuery();

answered Sep 16, 2020 at 3:05

rey123

2971 gold badge3 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

kevin Over a year ago

There are other issues here. You shouldn't post your connection string info on the internet. Also concatenating your sql statement leaves you open for sql injection attacks.

Collectives™ on Stack Overflow

Update SQL Query not working ASP.NET Core C# Console App

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related