Loop over a function and use its random output within a variable

Question

How can I improve this code:

import random
def rand_mac():
    return "00:00:00:%02x:%02x:%02x" % (
        random.randint(0, 255),
        random.randint(0, 255),
        random.randint(0, 255)
        )
add_acl_mac = rand_mac()
add_acl = 'mac access-list extended name test deny src {}-{} dst any\r\n'.format(add_acl_mac, add_acl_mac)
acl_list = 1
while (acl_list <=1024):
    network.sendline(add_acl)
    acl_list += 1

Current behavior: the loop writes the same MAC 1023 times.

Proposed behavior: the loop will write at each iteration a different MAC, for 1023 times.

I've been reading about generators and yield but I fail to understand how to properly use them in my current situation, if indeed they are to be used.

Thanks!

Call your function in the loop

Cid
– Cid

2020-10-06 13:42:53 +00:00
Commented Oct 6, 2020 at 13:42 — Cid
– Cid, Commented Oct 6, 2020 at 13:42

timgeb · Accepted Answer · 2020-10-06 13:43:10Z

1

Move the lines

add_acl_mac = rand_mac()
add_acl = 'mac access-list extended name test deny src {}-{} dst any\r\n'.format(add_acl_mac, add_acl_mac)

inside the for loop.

Currently you are generating add_acl with the output from rand_mac() only once.

answered Oct 6, 2020 at 13:43

timgeb

79.2k20 gold badges129 silver badges150 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

hjpotter92 · Accepted Answer · 2020-10-06 13:42:46Z

1

for _ in range(1024):
    add_acl_mac = rand_mac()
    add_acl = 'mac access-list extended name test deny src {}-{} dst any\r\n'.format(add_acl_mac, add_acl_mac)
    network.sendline(add_acl)

put the mac generation code inside loop as well.

answered Oct 6, 2020 at 13:42

hjpotter92

81.1k36 gold badges148 silver badges188 bronze badges

Collectives™ on Stack Overflow

Loop over a function and use its random output within a variable

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related