How to write while loop more efficiently in python?

Question

I have written a code using while loop. However I have written the code successfully but it is not efficient. Please see the while loop: -

struct_type = { 1:'slab', 2:'beam', 3:'column', 4:'footing' }
z = int(input("Enter the structure type as 1-slab,2-beam,3-column,4-footing"))
while (z != 1 and z != 2 and z != 3 and z != 4):
    print("Invalid Structure type")
    z = int(input("Enter only: 1-slab,2-beam,3-column,4-footing"))
print(z)

How to write this while loop more efficiently? For example

while (z != [1, 2, 3, 4]):

or

while (z != range(1:5)):

But both these give errors. please help in writing this while loop more efficiently.

Did you mean: while z not in [1,2,3,4]:?

quamrana
– quamrana

2020-11-10 15:05:03 +00:00
Commented Nov 10, 2020 at 15:05 — quamrana
– quamrana, Commented Nov 10, 2020 at 15:05

stark · Accepted Answer · 2020-11-10 15:08:07Z

1

Just compare to limits:

while z < 1 or z > 4:

answered Nov 10, 2020 at 15:08

stark

13.3k3 gold badges39 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

DeepSpace · Accepted Answer · 2020-11-10 15:08:50Z

1

You can use while z not in range(1, 5) which is pretty efficient (in checks in range objects is O(1)).

You can also do while z not in struct_type since 1..4 are keys of struct_type. This is also O(1).

answered Nov 10, 2020 at 15:08

DeepSpace

82.1k12 gold badges119 silver badges166 bronze badges

Comments

go2nirvana · Accepted Answer · 2020-11-10 15:08:08Z

0

I think you are looking for in clause.

while z not in [1,2,3,4]:

answered Nov 10, 2020 at 15:08

go2nirvana

1,68314 silver badges23 bronze badges

Collectives™ on Stack Overflow

How to write while loop more efficiently in python?

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related