Problem in finding the least number in the array in C

Question

This is the C program that I've written to find the least element in the given array.

But the output is "0" every time. I've checked other websites too but I found no problem in my program. Can anyone please rectify the problem in this program. (Thanks in advance)

#include <stdio.h>
main()
{
    int i,least,x[10];
    printf("Enter the elements into the array\n");

    for (i=0;i<10;i++)
    {
        scanf("%d",&x[10]);
    }
    least=x[0];
    for (i=1;i<10;i++)
    {
        if(least > x[i])
        {
            least=x[i];
        }
    }
    printf("The least element in the array is %d", least);
 }

You may want to check your understanding of: 1) the number of elements x has space for. 2) What &x[10] means. — gspr
– gspr, Commented Jan 6, 2021 at 13:56
You want &x[i] in your scanf(). Right now you always wrote to the 11th element of the array, leading to a buffer overflow btw. — Matthieu
– Matthieu, Commented Jan 6, 2021 at 13:57
When you fill an array you should write scanf("%d",&x[i]); (each case has one value) but in your code you write scanf("%d",&x[10]); so you fill the 10th case for 10 times — MED LDN
– MED LDN, Commented Jan 6, 2021 at 13:59
@Jarvis it's true that when the typo is corrected, there is no more question! ;) — Matthieu
– Matthieu, Commented Jan 6, 2021 at 13:59

Sourav Ghosh · Accepted Answer · 2021-01-06 13:55:33Z

8

In your code

 scanf("%d",&x[10]);

should be

 scanf("%d",&x[i]);
              ^^^

as you'd need to loop over the array element by element and the counter is i.

Also, by using index 10 on a 10-element array, you're off-by-one, accessing out of bound memory and invoking undefined behavior.

That said,

Use a proper signature for main(), for a hosted one, the minimalistic one would be int main(void).
Always check for success of scanf() for user inputs. Avoid using scanf() at all costs, use fgets() for better.

answered Jan 6, 2021 at 13:55

Sourav Ghosh

135k17 gold badges192 silver badges271 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ravi Kumar Over a year ago

Thanks. How much time did you take to spot that?

Collectives™ on Stack Overflow

Problem in finding the least number in the array in C

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related