PHP/MySQL verifying the result of a query?

Question

I've got this code that should delete a row, containing a certain number from the database.

if ( isset($_POST['textfield_numtodelete']) )
{

$numToDel = $_POST['textfield_numtodelete'];

$resdel = mysqli_query( $con,"DELETE FROM pncall_numbers WHERE Number = '$numToDel'");

if ( $resdel ) { echo ("<center>".$numToDel." deleted successfully.</center>"); } else { echo("<center>".$numToDel." not found in database.</center>"); }

}

If successful, it should output "deleted successfully", else "not found in database". Yet $resdel always is true, even if I try to delete a number that's not there...

Thanks!

Please note that this is vulnerable to SQL injections. Furthermore, quoting a number isn't standard SQL. — phant0m
– phant0m, Commented Jul 3, 2011 at 13:30
As a side note you really need to escape the $numToDel parameter: $mysqli->real_escape_string($numToDel) — Roland Mai
– Roland Mai, Commented Jul 3, 2011 at 13:30
For $numToDel, you can also use intval(). That converts the string to an integer. — ComFreek
– ComFreek, Commented Jul 3, 2011 at 13:32

Tak · Accepted Answer · 2011-07-03 13:28:34Z

3

true is returned because the query was successfully executed, even if no rows were deleted. Try mysqli->affected_rows after deletion

answered Jul 3, 2011 at 13:28

Tak

11.8k5 gold badges33 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Bilal Murtaza Over a year ago

Roger, if this answer helped you then please select this as "Answer".

Collectives™ on Stack Overflow

PHP/MySQL verifying the result of a query?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related