Ruby syntax to avoid nil input being returned as zero

Question

a Rails application has a sanitizing method

def mobile=(value)
  super(value.to_s.gsub(/\s+/, "").to_i) unless value.nil?
end

Yet, when submitting via console the following

User.last.update(mobile: nil)

the record was obviously processed to_i returning a 0

mobile: 0

implying that the syntax unless value.nil? is inappropriate. How should the method be expressed to no fire when the value submitted is nil ?

What is the value of User.last.mobile before the update? And do you have any database defaults set for the column? — 3limin4t0r
– 3limin4t0r, Commented Jan 28, 2021 at 19:26

SteveTurczyn · Accepted Answer · 2021-01-28 19:30:28Z

1

Because you're only calling super if the value is not nil, that means the value is NOT replaced when the value is nil. So if the value contained 0 then it'll still contain 0 afterwards.

If you want to be able to set the value to nil, you should do...

def mobile=(value)
  super(
    value.nil? ? nil : value.to_s.gsub(/\s+/, "").to_i
       )
end

answered Jan 28, 2021 at 19:30

SteveTurczyn

37k6 gold badges46 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Ruby syntax to avoid nil input being returned as zero

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related